Entrapment gives half duration in PvP, and no duration if DR'd

[Apathyxia]

Triage

Original CC issue: chromiecraft/chromiecraft#8058

Triage notes (rev: a953710):

As the reported pointed out, the already reported issue is still valid as well. This one further explains a new side of Entrapment talent not working as intended. Both reports have significance in PvP.

Testing process:
Have two accounts; one hunter and one anything else.
Learn entrapment (second row of survival talents) 1/3, 2/3 or 3/3.
.teleport gurubashi on both characters
Put frost or snake trap underneath the opponent and observe the root durations
Then put the other trap down and observe no root happens at all

When using the traps on NPCs, the trap duration is actually correct (4/3/2s respectively with 3/2/1 points in the talent) without having DR as is supposed to be.

Current Behaviour

I am aware of an already reported issue here where the Hunter talent Entrapment procs its root around the Hunter instead of where the trap is located. Tested this and confirmed it's still bugged as described by Nyeriah's comment.

Beyond that, the root is supposed to last 2, 3, or 4 seconds with 1, 2, and 3 points investment in the talent respectively. This currently works as intended against NPCs, but in PvP, it only lasts 1, 1.5, or 2 seconds.

Furthermore, after you proc this once on an enemy PC and trigger diminishing returns, subsequent traps will not root at all until the DR period has expired.

Expected Blizzlike Behaviour

The Entrapment proc should root for the full duration in PvP, and DR should function normally with second application getting half duration, and third getting quarter duration.

Source

Wowpedia page from November 2010 (end of retail Wrath) lists Entrapment as 4s duration in both PvE and PvP, shares DR with itself only, in PvP only: https://wowpedia.fandom.com/wiki/Diminishing_returns?oldid=2514132

WotLK Classic official tournament, you can see root icon under warriors unit frame @ bottom of screen lasts for 3s (Homerjay likely only put 2/3 in the talent, but regardless that's lasting longer than the 2s 3/3 gives on Chromie) when frost trap is triggered: https://youtu.be/BdES4MHiuzU?t=2598

Later same fight, you can see snake trap go down with 3s root followed by DR'd 1.5s root off frost trap: https://youtu.be/BdES4MHiuzU?t=2641

Steps to reproduce the problem

1. Make Hunter on PTR with 1 point in Entrapment, leave yourself 2 unspent points
2. Get a friend or second account, go in AV, put traps under both NPCs and PCs and notice the difference; test against multiple classes, make sure they don't have any talents that reduce the duration of movement-impairing effects
3. Put second trap under PC during DR period and notice there is no root proc at all
4. Add a second point in Entrapment, test again
5. Add a third point in Entrapment, test again

Extra Notes

No response

AC rev. hash/commit

chromiecraft@6de87af

Operating system

Windows 10

Modules

• mod-1v1-arena
• mod-ah-bot
• mod-anticheat
• mod-arena-3v3-solo-queue
• mod-arena-replay
• mod-bg-item-reward
• mod-breaking-news-override
• mod-cfbg
• mod-chat-transmitter
• mod-chromie-xp
• mod-costumes
• mod-cta-switch
• mod-desertion-warnings
• mod-dmf-switch
• mod-duel-reset
• mod-eluna
• mod-instanced-worldbosses
• mod-ip-tracker
• mod-low-level-arena
• mod-low-level-rbg
• mod-multi-client-check
• mod-npc-spectator
• mod-progression-system
• mod-pvp-titles
• mod-pvpstats-announcer
• mod-queue-list-cache
• mod-rdf-expansion
• mod-transmog
• mod-weekend-xp
• mod-zone-difficulty
• lua-CarbonCopy
• lua-eventScripts
• lua-ExchangeNpc
• lua-LevelUpReward
• lua-RecruitAFriend
• lua-SendAndBind
• lua-TempAnnouncements
• lua-Zonecheck

Customizations

None

Server

ChromieCraft