Bug: Issues in disabled items list

[dedmen]

Current Behaviour

Many things are in the disabled items list, even though they are valid, and are actually being sold in AH on "real" servers.

In my fork I have imported a list of item prices from Auctioneer addon data from a very big server, so items that are sold in the real world.
Using that to filter the disabled items list, I find that there are about 270 items in the disabled list, that are actually being sold in real AH's.

Using this to keep a list of wrong things.

These are just normal fish. I was already confused why I can sell Mud Snappers on auction house, but Smallfish I can't, even though they are both fished together in the same region.

The Oily Blackmouth is even an alchemy trade good, which is quite useful.

One note, the subclass 0 ones are rare fishes. But they can still be sold (and usually for quite high prices)
I have also included some rare fish (like 21 pound lobster, 32 pound salmon, 103 pound mightfish) that don't have a price in my data, but that is simply because they are so ultra rare, not because they are unavailable

entry	class	subclass	name
6291	7	8	Raw Brilliant Smallfish
6292	15	0	10 Pound Mud Snapper
6294	15	0	12 Pound Mud Snapper
6295	15	0	15 Pound Mud Snapper
6309	15	0	17 Pound Catfish
6310	15	0	19 Pound Catfish
6311	15	0	22 Pound Catfish
6358	7	11	Oily Blackmouth
6359	7	11	Firefin Snapper
6363	15	0	26 Pound Catfish
6364	15	0	32 Pound Catfish
8365	7	8	Raw Mithril Head Trout
13754	7	8	Raw Glossy Mightfish
13755	0	5	Winter Squid
13756	7	8	Raw Summer Bass
13758	7	8	Raw Redgill
13759	7	8	Raw Nightfin Snapper
13760	7	8	Raw Sunscale Salmon
13876	15	0	40 Pound Grouper
13877	15	0	47 Pound Grouper
13878	15	0	53 Pound Grouper
13879	15	0	59 Pound Grouper
13880	15	0	68 Pound Grouper
13882	15	0	42 Pound Redgill
13883	15	0	45 Pound Redgill
13884	15	0	49 Pound Redgill
13885	15	0	34 Pound Redgill
13886	15	0	37 Pound Redgill
13887	15	0	52 Pound Redgill
13901	15	0	15 Pound Salmon
13902	15	0	18 Pound Salmon
13903	15	0	22 Pound Salmon
13904	15	0	25 Pound Salmon
13905	15	0	29 Pound Salmon
13906	15	0	32 Pound Salmon
13907	15	0	7 Pound Lobster
13908	15	0	9 Pound Lobster
13910	15	0	15 Pound Lobster
13911	15	0	19 Pound Lobster
13912	15	0	21 Pound Lobster
13914	15	0	70 Pound Mightfish
13915	15	0	85 Pound Mightfish
13916	15	0	92 Pound Mightfish
13917	15	0	103 Pound Mightfish
13888	7	8	Darkclaw Lobster
13889	7	8	Raw Whitescale Salmon
13890	7	8	Plated Armorfish
13893	0	5	Large Raw Mightfish
21071	7	8	Raw Sagefish
21153	7	8	Raw Greater Sagefish
27422	7	8	Barbed Gill Trout
27437	7	8	Icefin Bluefish
33823	7	8	Bloodfin Catfish
33824	7	8	Crescent-Tail Skullfish
41801	7	8	Moonglow Cuttlefish
41802	7	8	Imperial Manta Ray
41803	7	8	Rockfin Grouper
41805	7	8	Borean Man O' War
41806	7	8	Musselback Sculpin
41807	7	8	Dragonfin Angelfish
41808	7	8	Bonescale Snapper
41809	7	8	Glacial Salmon
41810	7	8	Fangtooth Herring
41812	7	8	Barrelhead Goby
41813	7	8	Nettlefish
41814	7	8	Glassfin Minnow
43571	7	8	Sewer Carp
43572	7	8	Magic Eater
43646	7	8	Fountain Goldfish
43647	7	8	Shimmering Minnow
43652	7	8	Slippery Eel

Enchanting supplies?? Ref #73

6216	7	12	Mystical Powder
6374	7	12	Enchanted Powder
10939	7	12	Greater Magic Essence
10978	7	12	Small Glimmering Shard
10998	7	12	Lesser Astral Essence
11082	7	12	Greater Astral Essence
11083	7	12	Soul Dust
11084	7	12	Large Glimmering Shard
11134	7	12	Lesser Mystic Essence
11135	7	12	Greater Mystic Essence
11137	7	12	Vision Dust
11138	7	12	Small Glowing Shard
11139	7	12	Large Glowing Shard
11174	7	12	Lesser Nether Essence
11175	7	12	Greater Nether Essence
11176	7	12	Dream Dust
11177	7	12	Small Radiant Shard
11178	7	12	Large Radiant Shard
14343	7	12	Small Brilliant Shard
14344	7	12	Large Brilliant Shard
16202	7	12	Lesser Eternal Essence
16203	7	12	Greater Eternal Essence
20725	7	12	Nexus Crystal
22446	7	12	Greater Planar Essence
22447	7	12	Lesser Planar Essence
22450	7	12	Void Crystal
34057	7	12	Abyss Crystal
41741	7	12	Cobalt Rod
44451	7	12	Runed Cobalt Rod
46849	7	12	Titanium Powder
49640	7	12	Essence or Dust

Tradegoods - Leather

15409	7	6	Refined Deeprock Salt
15410	7	6	Scale of Onyxia
15415	7	6	Blue Dragonscale
15417	7	6	Devilsaur Leather
15419	7	6	Warbear Leather
17012	7	6	Core Leather
20498	7	6	Silithid Chitin
20500	7	6	Light Silithid Carapace
20501	7	6	Heavy Silithid Carapace
25699	7	6	Crystal Infused Leather
25700	7	6	Fel Scales
29539	7	6	Cobra Scales
29547	7	6	Wind Scales
29548	7	6	Nether Dragonscales
38561	7	6	Jormungar Scale

Tradegoods - Ore

10620	7	7	Thorium Ore
36910	7	7	Titanium Ore
36912	7	7	Saronite Ore
22202	7	7	Small Obsidian Shard

Tradegoods - Herb

22710	7	9	Bloodthistle
22788	7	9	Flame Cap
22797	7	9	Nightmare Seed

Tradegoods - Other

37164	7	11	Swords Deck
39151	7	11	Alabaster Pigment
39334	7	11	Dusky Pigment
39338	7	11	Golden Pigment
39339	7	11	Emerald Pigment
39340	7	11	Violet Pigment
39341	7	11	Silvery Pigment
39342	7	11	Nether Pigment
39343	7	11	Azure Pigment
40199	7	11	Pygmy Suckerfish
43103	7	11	Verdant Pigment
43104	7	11	Burnt Pigment
43105	7	11	Indigo Pigment
43106	7	11	Ruby Pigment
43107	7	11	Sapphire Pigment
43108	7	11	Ebon Pigment
43109	7	11	Icy Pigment
43561	7	11	Iridescent Pollen
45909	7	11	Giant Darkwater Clam

Consumable - Food&Drink

12238	0	5	Darkshore Grouper
13755	0	5	Winter Squid
13893	0	5	Large Raw Mightfish
20709	0	5	Rumsey Rum Light
21114	0	5	Rumsey Rum Dark
42434	0	5	Lovely Cake Slice
43087	0	5	Crisp Dalaran Apple
43695	0	5	Half Full Bottle of Prison Moonshine

Some other misc things (That are definitely sold in real AH's, I actually have prices for all these, exported from Auctioneer data)

3260	4	1	Scarlet Initiate Robes
6360	2	4	Steelscale Crushfish
6366	2	20	Darkwood Fishing Pole
6651	2	4	Broken Wine Bottle
7287	15	0	Red Whelp Scale
8350	4	0	The 1 Ring
8383	15	0	Plain Letter
9718	2	7	Reforged Blade of Heroes
11903	15	2	Cat Carrier (Corrupted Kitten)
17195	15	0	Fake Mistletoe
19808	2	4	Rockhide Strongfish
21536	15	3	Elune Stone
21816	15	3	Heart Candy
21817	15	3	Heart Candy
21818	15	3	Heart Candy
21819	15	3	Heart Candy
21820	15	3	Heart Candy
21821	15	3	Heart Candy
21822	15	3	Heart Candy
21823	15	3	Heart Candy
22795	0	0	Fel Blossom
23773	6	3	Adamantite Shells
23858	15	0	Singed Page
23866	15	0	Singed Page
23867	15	0	Singed Page
23868	15	0	Singed Page
24243	7	4	Adamantite Powder
30438	13	0	Cache of the Legion Key
32598	0	3	Unstable Flask of the Beast
32601	0	3	Unstable Flask of the Sorcerer
32655	4	1	Crystalweave Bracers
32656	4	3	Crystalhide Handwraps
32658	4	0	Badge of Tenacity
32659	2	15	Crystal-Infused Shiv
32660	2	7	Crystalforged Sword
32662	2	10	Flaming Quartz Staff
32664	4	0	Dreamcrystal Band
33081	0	8	Voodoo Skull
33803	6	2	Adamantite Stinger
34622	2	16	Spinesever
35202	9	10	Design: Amulet of Flowing Life
36862	0	0	Worn Troll Dice
36863	0	0	Decahedral Dwarven Dice
37163	15	4	Rogues Deck
37196	4	1	Runecaster's Mantle
37197	4	1	Tattered Castle Drape
37243	4	2	Treasure Seeker's Belt
37290	4	0	Dragon Prow Amulet
37364	4	0	Frostbridge Orb
37365	4	3	Bands of the Sky Ring
37366	4	2	Drake-Champion's Bracers
37410	2	16	Tracker's Balanced Knives
37587	4	2	Ymirjar Physician's Robe
37590	4	4	Bands of Fading Light
37624	4	0	Stained-Glass Shard Ring
37625	4	4	Web Winder Gloves
37646	4	0	Burning Skull Pendant
37647	4	1	Cloak of Bloodied Waters
37648	4	3	Belt of Tasseled Lanterns
37671	4	4	Refined Ore Gloves
37672	4	4	Patina-Coated Breastplate
37673	4	1	Dark Runic Mantle
37799	4	1	Reanimator's Cloak
37800	4	3	Aviary Guardsman's Hauberk
37801	4	4	Waistguard of the Risen Knight
37856	2	15	Librarian's Paper Cutter
37857	4	3	Helm of the Lightning Halls
37858	4	2	Awakened Handguards
38266	0	8	Rotund Relic
39472	4	0	Chain of Latent Energies
39969	0	8	Fire Seed
40110	0	0	Haunted Memento
41166	0	1	Runic Healing Injector
42545	0	1	Runic Mana Injector
43611	2	7	Krol Cleaver
43612	2	16	Spineslicer
43613	2	15	The Dusk Blade
44148	15	4	Mages Deck
44158	15	4	Demons Deck
44310	2	15	Namlak's Supernumerary Sticker
44311	2	7	Avool's Sword of Jin
44505	2	15	Dustbringer
44703	2	15	Dark Herring
49916	4	0	Lovely Charm Bracelet

I think we should clean up the disabled list.
Sort things by categories (Like "Depreacated prefix") and such.

And also instead of just hardcoding a list, do it using queries. For example we can Query for items with Flags&0x10, to get all items already flagged as deprecated. Then we don't need to list them separately.

• ITEM_FLAG_DEPRECATED is 1595 items
• ITEM_FLAG_CONJURED is 114 items

(Excluding the flag checks above)

• item_template.name LIKE '%DEPRECATED%' 17 items
• item_template.name LIKE '[PH]%' 103 items
• item_template.name LIKE '%deprecated%' 14 items
• item_template.name LIKE '%test%' 72 items
• item_template.name LIKE 'QA%' 25 items
• item_template.name LIKE 'zzOLD%' 26 items
• item_template.name LIKE 'CRobinson%' 14 items
• bonding = 1 is 2501 items (even though we have separate config option to disable BOP items)
• class=15 & subclass=0 & description!="" & item_template.name LIKE '% Coin' 53 items (dalaran fountain coins) (40 of these are already disabled, somehow we're missing a few)

With these, that leaves about 1200 items to manually disable (instead of the previous 4500)

Expected Behaviour

Items that are commonly sold should not be disabled.

Steps to reproduce the problem

Use the normal SQL setup files.

Extra Notes

No response

AC rev. hash/commit

AC fd2869f283fddb7190c9202f2e859747c7150cb7

Operating system

Debian

Custom changes or Modules

No response