From 29018dea0226cc36dc6ee00dfc6734795a3f6eb3 Mon Sep 17 00:00:00 2001 From: wermos <63574588+wermos@users.noreply.github.com> Date: Sun, 15 Jun 2025 12:04:21 +0530 Subject: [PATCH 1/4] Temporarily add this branch to CI. --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0fb1f6a..db22fb5 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -5,7 +5,7 @@ name: CI Tests on: workflow_dispatch: push: - branches: [main] + branches: [main, ci] pull_request: branches: [main] jobs: From b23346708e4b0d8e45815e698c3b2f626aff1171 Mon Sep 17 00:00:00 2001 From: wermos <63574588+wermos@users.noreply.github.com> Date: Sun, 15 Jun 2025 12:10:24 +0530 Subject: [PATCH 2/4] Remove the unnecessary install Ninja step. --- .github/workflows/ci.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index db22fb5..977c27c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -26,10 +26,9 @@ jobs: - {name: "Ubuntu GCC 12", os: ubuntu-24.04, toolchain: "gcc-12", cmake_args: "-G \"Ninja Multi-Config\" -DCMAKE_CONFIGURATION_TYPES=\"RelWithDebInfo;Asan\" "} steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: submodules: 'true' - - uses: seanmiddleditch/gha-setup-ninja@master - name: Activate verbose shell run: set -x - name: Install LLVM+Clang From cec8661c9f39454d2a4af9b21f5cd5f13e843ae4 Mon Sep 17 00:00:00 2001 From: wermos <63574588+wermos@users.noreply.github.com> Date: Sun, 15 Jun 2025 12:17:06 +0530 Subject: [PATCH 3/4] No need to keep doing `set -x`; the `.build` directory doesn't exist so no need to remove it. --- .github/workflows/ci.yml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 977c27c..4a1dc09 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -34,7 +34,6 @@ jobs: - name: Install LLVM+Clang if: startsWith(matrix.config.name, 'Ubuntu Clang') run: | - set -x cat /etc/lsb-release # Remove existing Clang installations. sudo apt-get remove \ @@ -70,7 +69,6 @@ jobs: - name: Install GCC if: startsWith(matrix.config.name, 'Ubuntu GCC') run: | - set -x # Remove existing GCC installations. sudo apt-get remove gcc-13 g++-13 gcc-14 g++-14 gcc g++ sudo apt update @@ -82,18 +80,14 @@ jobs: g++-${GCC_VERSION} --version - name: CMake Configure run: | - set -x echo ${{ matrix.config.cmake_args }} echo ${{ matrix.config.toolchain }} - rm -rf .build cmake ${{ matrix.config.cmake_args }} -DCMAKE_TOOLCHAIN_FILE="etc/${{ matrix.config.toolchain }}-toolchain.cmake" -B .build -S . - name: CMake Build run: | - set -x cmake --build .build --config Asan --target all -- -k 0 - name: CMake Test run: | - set -x [[ ! -z "${{ matrix.config.asan_options }}" ]] && export ASAN_OPTIONS="${{ matrix.config.asan_options }}" ctest --build-config Asan --output-on-failure --test-dir .build From db8bf638d62d874bde3f3ec17d1b8e6b5bf8ca79 Mon Sep 17 00:00:00 2001 From: wermos <63574588+wermos@users.noreply.github.com> Date: Sun, 15 Jun 2025 12:20:30 +0530 Subject: [PATCH 4/4] No need for printing the OS version every CI run. --- .github/workflows/ci.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 4a1dc09..b6295a6 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -34,7 +34,6 @@ jobs: - name: Install LLVM+Clang if: startsWith(matrix.config.name, 'Ubuntu Clang') run: | - cat /etc/lsb-release # Remove existing Clang installations. sudo apt-get remove \ clang-${{matrix.config.installed_clang_version}} \