Skip to content

BIP127: Replace network_magic with BIP44 coin_type in ProofOfReserves message #1834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

BIP127: Replace network_magic with BIP44 coin_type in ProofOfReserves message #1834

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions bip-0127.mediawiki
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,11 +133,10 @@ message ProofOfReserves {
// additional fields.
uint32 version = 1;

// The network magic for the network in which the proofs are valid.
// 0xD9B4BEF9 for mainnet, 0x0709110B for testnet
//TODO consider BIP44 coin type ids instead:
// https://github.com/satoshilabs/slips/blob/master/slip-0044.md
uint32 network_magic = 2;
// The coin type id from SLIP-0044 for the network in which the proofs are valid.
// 0 (0x80000000) for Bitcoin mainnet, 1 (0x80000001) for Testnet (all coins)
// See SLIP-0044 for the full registry: https://github.com/satoshilabs/slips/blob/master/slip-0044.md
uint32 coin_type = 2;

// The commitment message for this proof-of-reserves.
// This message is global for all the proofs.
Expand Down