Skip to content

[Bug]: Neutral NPC's Merge Segments with Boss #120

Open
@EduardoJCI

Description

@EduardoJCI

Are you using the latest version of the addon?

  • Yes
  • No

Addon Version

Skada: Version: 1.8.87 - Date: 2024-03-23 @ 11:22 UTC

Did you try having only this addon enabled?

  • Yes
  • No

Current Behavior

When a neutral NPC is killed before a boss fight, these two segments are merged into one, resulting in an incorrect timer — and therefore incorrect DPS views and sub-views.
This is some of the Neutral NPC that causes this issue
[2110] = "Black Rat",
[3444] = "Dig Rat",
[4076] = "Roach",
[14881] = "Spider",
[38228] = "Plagued Insect",
[38231] = "Blood Parasite",
[38232] = "Blood Spider",

Expected Behavior

When a neutral NPC is killed before a boss fight, it should be ignored or end the segment of that NPC Fight immediately so a merge cannot be done

Lua Error

No response

Reproduction Steps

  1. Go to ICC
  2. Kill one of the mentioned NPCS 12-8seconds before pull starts
  3. Take time of the real fight and compare with Skada results, u will see that, more seconds are added into the boss fight
  4. (optional) Compare kill time and DPS to any DPS Log Parser like Ridepad's

Last Good Version

No response

Screenshots

No response

Metadata

Metadata

Assignees

Labels

type: bugSomething isn't working

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions