Merge pull request #3559 from bolt/implicit-nullable-parameter

Fix implicitly nullable parameters

Author: bobvandevijver

src/Repository/UserRepository.php

@@ -50,7 +50,7 @@ public function findOneByCredentials(string $username): ?User
         return $user instanceof User ? $user : null;
     }
 
-    public function findUsers(string $like, string $orderBy = null)
+    public function findUsers(string $like, ?string $orderBy = null)
     {
         $alias = 'user';
         $qb = $this->createQueryBuilder($alias);

src/Security/AuthenticationEntryPointRedirector.php

@@ -22,7 +22,7 @@ public function __construct(TranslatorInterface $translator, UrlGeneratorInterfa
         $this->urlGenerator = $urlGenerator;
     }
 
-    public function start(Request $request, AuthenticationException $authException = null): RedirectResponse
+    public function start(Request $request, ?AuthenticationException $authException = null): RedirectResponse
     {
         // add a custom flash message and redirect to the login page
         /** @var Session $session */

src/Twig/AssetsExtension.php

@@ -41,7 +41,7 @@ public function getFunctions(): array
      * If the package used to generate the path is an instance of
      * UrlPackage, you will always get a URL and not a path.
      */
-    public function getAssetUrl(string $path, string $packageName = null): string
+    public function getAssetUrl(string $path, ?string $packageName = null): string
     {
         $url = $this->assets->getAssetUrl($path, $packageName);
         $original = $url;

src/Utils/FilesIndex.php

@@ -48,7 +48,7 @@ public function get(string $path, string $type, string $baseUrlPath, string $bas
         return new Collection($files);
     }
 
-    private function findFiles(string $path, string $glob = null): Finder
+    private function findFiles(string $path, ?string $glob = null): Finder
     {
         $finder = new Finder();
         $finder->in($path)->depth('0')->sortByType()->files();