fix: get by id returns null on 404

Author: carloeusebi

src/RegistroSportESalute.php

@@ -23,10 +23,10 @@
  * @phpstan-type OrganizationDetailData array{
  *     stato: int,
  *     errori: list<mixed>,
- *     payload: array{
- *      testata: array<string, string>,
- *      immagine: array<string, string>,
- *      corpo: array{
+ *     payload?: array{
+ *      testata?: array<string, string>,
+ *      immagine?: array<string, string>,
+ *      corpo?: array{
  *          dati: list<array{ label: string, tipo: 'input'|'textarea'|'number', value: string|int }>
  *      }
  *     },
@@ -110,11 +110,11 @@ public function get(): Collection
     }
 
     /**
-     * @return array<string, int|string|null>
+     * @return array<string, int|string|null>|null
      *
      * @throws RequestException
      */
-    public function getById(int $id): array
+    public function getById(int $id): ?array
     {
         $key = "registro-sport-e-salute.detail.$id";
 
@@ -128,6 +128,10 @@ public function getById(int $id): array
                 ->throwUnlessStatus(200)
                 ->json();
 
+            if (! isset($res['payload']) || empty($res['payload'])) {
+                return null;
+            }
+
             return Arr::mapWithKeys($res['payload']['corpo']['dati'], fn (array $dato) => [$dato['label'] => $dato['value']]);
         });
     }

src/Testing/Fakes/RegistroSportESaluteFake.php

@@ -5,6 +5,7 @@
 use CarloEusebi\RegistroSportESalute\Factories\OrganizationFactory;
 use CarloEusebi\RegistroSportESalute\RegistroSportESalute;
 use Faker\Factory;
+use Illuminate\Http\Client\RequestException;
 use Illuminate\Support\Collection;
 use Illuminate\Support\Facades\Http;
 use Illuminate\Support\Testing\Fakes\Fake;
@@ -34,7 +35,12 @@ public function get(): Collection
         return collect(array_fill(0, $this->count, OrganizationFactory::create()));
     }
 
-    public function getById(int $id): array
+    /**
+     * @return array<string, int|string|null>|null
+     *
+     * @throws RequestException
+     */
+    public function getById(int $id): ?array
     {
         if ($this->shouldThrowHttpException) {
             Http::fake([

tests/Feature/RegistroSportESaluteTest.php

@@ -72,6 +72,24 @@
     expect(RegistroSportESalute::getCount())->toBe(5);
 });
 
+it('handles 404 on get by id', function (): void {
+    Http::fake([
+        'https://registro.sportesalute.eu/api/istruttoria/*/sidebar*' => Http::response([
+            'stato' => 0,
+            'payload' => [],
+            'errori' => [
+                0 => [
+                    'codice' => '404',
+                    'campo' => '',
+                    'messaggio' => 'Non trovato',
+                ],
+            ],
+        ]),
+    ]);
+
+    expect(RegistroSportESalute::getById(1))->toBeNull();
+});
+
 describe('exceptions', function (): void {
     beforeEach(function (): void {
         Http::fake([