What is the correct way to implement OnBeforeDownload of the IDownloadHandler interface.

[smunnik]

Previously OnBeforeDownload did not return a value and my code looked like this:

public class DownloadHandler : IDownloadHandler
{
    public void OnBeforeDownload(IWebBrowser chromiumWebBrowser, IBrowser browser, DownloadItem downloadItem,
        IBeforeDownloadCallback callback)
    {
        if (!callback.IsDisposed)
        {
            using (callback)
            {
                callback.Continue(null, true);
            }
        }
    }

Now it must return a bool and I don’t know what the return value indicates.

Should true always be returned?

public bool OnBeforeDownload(IWebBrowser chromiumWebBrowser, IBrowser browser, DownloadItem downloadItem, 
    IBeforeDownloadCallback callback)
{
    if (!callback.IsDisposed)
    {
        using (callback)
        {
            callback.Continue(null, true);
        }
    }
    return true;
}

Or are there circumstances when false should be returned?

 public bool OnBeforeDownload(IWebBrowser chromiumWebBrowser, IBrowser browser, DownloadItem downloadItem, 
     IBeforeDownloadCallback callback)
 {
     if (!callback.IsDisposed)
     {
         using (callback)
         {
             callback.Continue(null, true);
         }
         return true;
     }
     return false;
 }

[amaitland]

Now it must return a bool and I don’t know what the return value indicates.

Did you read the documentation?

https://github.com/cefsharp/CefSharp/blob/cefsharp/135/CefSharp/Handler/IDownloadHandler.cs#L32