Skip to content

Commit 86957ce

Browse files
Fix special characters encoding in fetch overlays
1 parent c77e64e commit 86957ce

File tree

2 files changed

+14
-5
lines changed

2 files changed

+14
-5
lines changed

cloudinary/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1289,7 +1289,7 @@ def process_layer(layer, layer_parameter):
12891289
text = ''.join(encoded_text)
12901290
components.append(text)
12911291
elif type == "fetch":
1292-
b64 = base64_encode_url(fetch_url)
1292+
b64 = base64url_encode(fetch_url)
12931293
components.append(b64)
12941294
else:
12951295
public_id = public_id.replace("/", ':')

test/test_utils.py

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -455,8 +455,18 @@ def test_fetch_overlay(self):
455455
expected_url=(
456456
DEFAULT_UPLOAD_PATH +
457457
"l_fetch:"
458-
"aHR0cHM6Ly91cGxvYWQud2lraW1lZGlhLm9yZy93aWtpcGVkaWEvY29"
459-
"tbW9ucy8yLzJiLyVFQSVCMyVBMCVFQyVCMCVCRCVFQSVCMCVBRiVFQiVCMiU4Qy5qcGc=/"
458+
"aHR0cHM6Ly91cGxvYWQud2lraW1lZGlhLm9yZy93aWtpcGVkaWEvY29tbW9ucy8yLzJiL-qzoOywveqwr-uyjC5qcGc=/"
459+
"test"))
460+
461+
self.__test_cloudinary_url(
462+
options={
463+
"overlay": {
464+
"url":
465+
"https://www.test.com/test/JE01118-YGP900_1_lar.jpg?version=432023"}},
466+
expected_url=(
467+
DEFAULT_UPLOAD_PATH +
468+
"l_fetch:"
469+
"aHR0cHM6Ly93d3cudGVzdC5jb20vdGVzdC9KRTAxMTE4LVlHUDkwMF8xX2xhci5qcGc_dmVyc2lvbj00MzIwMjM=/"
460470
"test"))
461471

462472
def test_underlay(self):
@@ -960,8 +970,7 @@ def test_overlay_options(self):
960970
'font_family': "Arial", 'font_size': 40},
961971
"subtitles:Arial_40:sample_sub_he.srt"),
962972
({'url': "https://upload.wikimedia.org/wikipedia/commons/2/2b/고창갯벌.jpg"},
963-
"fetch:aHR0cHM6Ly91cGxvYWQud2lraW1lZGlhLm9yZy93aWtpcGVkaWEvY29"
964-
"tbW9ucy8yLzJiLyVFQSVCMyVBMCVFQyVCMCVCRCVFQSVCMCVBRiVFQiVCMiU4Qy5qcGc="),
973+
"fetch:aHR0cHM6Ly91cGxvYWQud2lraW1lZGlhLm9yZy93aWtpcGVkaWEvY29tbW9ucy8yLzJiL-qzoOywveqwr-uyjC5qcGc="),
965974
({'url': FETCH_VIDEO_URL, "resource_type": "video"},
966975
"video:fetch:aHR0cHM6Ly9kZW1vLXJlcy5jbG91ZGluYXJ5LmNvbS92aWRlb3MvZG9nLm1wNA==")
967976
]

0 commit comments

Comments
 (0)