`./mill init` doesn't seem to set proper java version for `iluwatar/java-design-patterns` repo

[lihaoyi]

Importing https://github.com/iluwatar/java-design-patterns via ./mill init and running ./mill __.compile results in a stack trace.

We should pick up the maven-compiler-plugin <source> and <target> versions in the root pom.xml and use that to configure our def jvmId. Passing --jvm-id from the command line seems to do nothing

The Gradle and SBT importers seem to set def jvmId, so the Maven importer not doing it seems like an oversight

[09960] [info] compiling 25 Java sources to /Users/lihaoyi/test/java-design-patterns/out/commander/compile.dest/classes ...
[09960] [error] ## Exception when compiling 25 sources to /Users/lihaoyi/test/java-design-patterns/out/commander/compile.dest/classes
[09960] [error] java.lang.IllegalArgumentException: error: invalid source release: 21
[09960] [error] jdk.compiler/com.sun.tools.javac.main.Arguments.error(Arguments.java:905)
[09960] [error] jdk.compiler/com.sun.tools.javac.main.Arguments.doProcessArgs(Arguments.java:383)
[09960] [error] jdk.compiler/com.sun.tools.javac.main.Arguments.processArgs(Arguments.java:347)
[09960] [error] jdk.compiler/com.sun.tools.javac.main.Arguments.init(Arguments.java:246)
[09960] [error] jdk.compiler/com.sun.tools.javac.api.JavacTool.getTask(JavacTool.java:191)
[09960] [error] jdk.compiler/com.sun.tools.javac.api.JavacTool.getTask(JavacTool.java:119)
[09960] [error] jdk.compiler/com.sun.tools.javac.api.JavacTool.getTask(JavacTool.java:68)
[09960] [error] sbt.internal.inc.javac.LocalJavaCompiler.run(LocalJava.scala:343)
[09960] [error] sbt.internal.inc.javac.AnalyzingJavaCompiler.$anonfun$compile$12(AnalyzingJavaCompiler.scala:173)
[09960] [error] scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.scala:18)
[09960] [error] sbt.internal.inc.javac.AnalyzingJavaCompiler.timed(AnalyzingJavaCompiler.scala:263)
[09960] [error] sbt.internal.inc.javac.AnalyzingJavaCompiler.compile(AnalyzingJavaCompiler.scala:161)
[09960] [error] sbt.internal.inc.MixedAnalyzingCompiler.$anonfun$compileJava$2(MixedAnalyzingCompiler.scala:104)
[09960] [error] sbt.internal.inc.MixedAnalyzingCompiler.$anonfun$compileJava$2$adapted(MixedAnalyzingCompiler.scala:92)
[09960] [error] sbt.internal.inc.JarUtils$.withPreviousJar(JarUtils.scala:241)
[09960] [error] sbt.internal.inc.MixedAnalyzingCompiler.$anonfun$compileJava$1(MixedAnalyzingCompiler.scala:92)
[09960] [error] scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.scala:18)
[09960] [error] sbt.internal.inc.MixedAnalyzingCompiler.timed(MixedAnalyzingCompiler.scala:252)
[09960] [error] sbt.internal.inc.MixedAnalyzingCompiler.compileJava(MixedAnalyzingCompiler.scala:61)
[09960] [error] sbt.internal.inc.MixedAnalyzingCompiler.compileJava0$1(MixedAnalyzingCompiler.scala:201)
[09960] [error] sbt.internal.inc.MixedAnalyzingCompiler.compile(MixedAnalyzingCompiler.scala:214)
[09960] [error] sbt.internal.inc.IncrementalCompilerImpl.$anonfun$compileInternal$1(IncrementalCompilerImpl.scala:542)
[09960] [error] sbt.internal.inc.IncrementalCompilerImpl.$anonfun$compileInternal$1$adapted(IncrementalCompilerImpl.scala:542)
[09960] [error] sbt.internal.inc.Incremental$.$anonfun$apply$3(Incremental.scala:182)
[09960] [error] sbt.internal.inc.Incremental$.$anonfun$apply$3$adapted(Incremental.scala:180)
[09960] [error] sbt.internal.inc.Incremental$$anon$2.run(Incremental.scala:458)
[09960] [error] sbt.internal.inc.IncrementalCommon$CycleState.next(IncrementalCommon.scala:116)
[09960] [error] sbt.internal.inc.IncrementalCommon$$anon$1.next(IncrementalCommon.scala:56)
[09960] [error] sbt.internal.inc.IncrementalCommon$$anon$1.next(IncrementalCommon.scala:52)
[09960] [error] sbt.internal.inc.IncrementalCommon.cycle(IncrementalCommon.scala:264)
[09960] [error] sbt.internal.inc.Incremental$.$anonfun$incrementalCompile$8(Incremental.scala:413)
[09960] [error] sbt.internal.inc.Incremental$.withClassfileManager(Incremental.scala:500)
[09960] [error] sbt.internal.inc.Incremental$.incrementalCompile(Incremental.scala:400)
[09960] [error] sbt.internal.inc.Incremental$.apply(Incremental.scala:208)
[09960] [error] sbt.internal.inc.IncrementalCompilerImpl.compileInternal(IncrementalCompilerImpl.scala:542)
[09960] [error] sbt.internal.inc.IncrementalCompilerImpl.$anonfun$compileIncrementally$1(IncrementalCompilerImpl.scala:496)
[09960] [error] sbt.internal.inc.IncrementalCompilerImpl.handleCompilationError(IncrementalCompilerImpl.scala:332)
[09960] [error] sbt.internal.inc.IncrementalCompilerImpl.compileIncrementally(IncrementalCompilerImpl.scala:433)
[09960] [error] sbt.internal.inc.IncrementalCompilerImpl.compile(IncrementalCompilerImpl.scala:137)
[09960] [error] mill.javalib.worker.JvmWorkerImpl.compileInternal(JvmWorkerImpl.scala:678)
[09960] [error] mill.javalib.worker.JvmWorkerImpl.compileJava$$anonfun$2(JvmWorkerImpl.scala:427)
[09960] [error] mill.util.CachedFactory.withValue(CachedFactory.scala:39)
[09960] [error] mill.javalib.worker.JvmWorkerImpl.compileJava(JvmWorkerImpl.scala:414)
[09960] [error] mill.javalib.JavaModule.compile$$anonfun$1$$anonfun$1(JavaModule.scala:826)
[09960] [error] mill.api.Task$Named.evaluate(Task.scala:328)
[09960] [error] mill.api.Task$Named.evaluate$(Task.scala:313)
[09960] [error] mill.api.Task$Computed.evaluate(Task.scala:339)
[09960] [error] mill.exec.GroupExecution.$anonfun$15(GroupExecution.scala:323)
[09960] [error] mill.exec.GroupExecution$.wrap$$anonfun$1$$anonfun$1$$anonfun$1$$anonfun$1(GroupExecution.scala:576)
[09960] [error] mill.api.Evaluator$.withCurrentEvaluator$$anonfun$2$$anonfun$1(Evaluator.scala:136)
[09960] [error] scala.util.DynamicVariable.withValue(DynamicVariable.scala:59)
[09960] [error] mill.api.Evaluator$.withCurrentEvaluator$$anonfun$2(Evaluator.scala:137)
[09960] [error] scala.util.Using$.resource(Using.scala:296)
[09960] [error] mill.api.Evaluator$.withCurrentEvaluator(Evaluator.scala:138)
[09960] [error] mill.exec.GroupExecution$.wrap$$anonfun$1$$anonfun$1$$anonfun$1(GroupExecution.scala:583)
[09960] [error] mill.api.SystemStreamsUtils$.withStreams$$anonfun$1$$anonfun$1$$anonfun$1$$anonfun$1$$anonfun$1$$anonfun$1$$anonfun$1(SystemStreamsUtils.scala:49)
[09960] [error] scala.util.DynamicVariable.withValue(DynamicVariable.scala:59)
[09960] [error] mill.api.SystemStreamsUtils$.withStreams$$anonfun$1$$anonfun$1$$anonfun$1$$anonfun$1$$anonfun$1$$anonfun$1(SystemStreamsUtils.scala:50)
[09960] [error] scala.util.DynamicVariable.withValue(DynamicVariable.scala:59)
[09960] [error] mill.api.SystemStreamsUtils$.withStreams$$anonfun$1$$anonfun$1$$anonfun$1$$anonfun$1$$anonfun$1(SystemStreamsUtils.scala:51)
[09960] [error] scala.util.DynamicVariable.withValue(DynamicVariable.scala:59)
[09960] [error] mill.api.SystemStreamsUtils$.withStreams$$anonfun$1$$anonfun$1$$anonfun$1$$anonfun$1(SystemStreamsUtils.scala:52)
[09960] [error] scala.util.DynamicVariable.withValue(DynamicVariable.scala:59)
[09960] [error] scala.Console$.withErr(Console.scala:193)
[09960] [error] mill.api.SystemStreamsUtils$.withStreams$$anonfun$1$$anonfun$1$$anonfun$1(SystemStreamsUtils.scala:53)
[09960] [error] scala.util.DynamicVariable.withValue(DynamicVariable.scala:59)
[09960] [error] scala.Console$.withOut(Console.scala:164)
[09960] [error] mill.api.SystemStreamsUtils$.withStreams$$anonfun$1$$anonfun$1(SystemStreamsUtils.scala:54)
[09960] [error] scala.util.DynamicVariable.withValue(DynamicVariable.scala:59)
[09960] [error] scala.Console$.withIn(Console.scala:227)
[09960] [error] mill.api.SystemStreamsUtils$.withStreams$$anonfun$1(SystemStreamsUtils.scala:55)
[09960] [error] scala.util.DynamicVariable.withValue(DynamicVariable.scala:59)
[09960] [error] mill.api.SystemStreamsUtils$.withStreams(SystemStreamsUtils.scala:56)
[09960] [error] mill.exec.GroupExecution$.wrap$$anonfun$1$$anonfun$1(GroupExecution.scala:584)
[09960] [error] scala.util.DynamicVariable.withValue(DynamicVariable.scala:59)
[09960] [error] mill.exec.GroupExecution$.wrap$$anonfun$1(GroupExecution.scala:585)
[09960] [error] scala.util.DynamicVariable.withValue(DynamicVariable.scala:59)
[09960] [error] mill.exec.GroupExecution$.wrap(GroupExecution.scala:586)
[09960] [error] mill.exec.GroupExecution.executeGroup$$anonfun$1(GroupExecution.scala:336)
[09960] [error] scala.runtime.function.JProcedure1.apply(JProcedure1.java:15)
[09960] [error] scala.runtime.function.JProcedure1.apply(JProcedure1.java:10)
[09960] [error] scala.collection.immutable.Vector.foreach(Vector.scala:2125)
[09960] [error] mill.exec.GroupExecution.executeGroup(GroupExecution.scala:275)
[09960] [error] mill.exec.GroupExecution.executeGroupCached$$anonfun$1(GroupExecution.scala:190)
[09960] [error] mill.api.daemon.Logger.withPromptLine(Logger.scala:74)
[09960] [error] mill.api.daemon.Logger.withPromptLine$(Logger.scala:12)
[09960] [error] mill.internal.PrefixLogger.withPromptLine(PrefixLogger.scala:21)
[09960] [error] mill.exec.GroupExecution.executeGroupCached(GroupExecution.scala:248)
[09960] [error] mill.exec.GroupExecution.executeGroupCached$(GroupExecution.scala:21)
[09960] [error] mill.exec.Execution.executeGroupCached(Execution.scala:18)
[09960] [error] mill.exec.Execution.evaluateTerminals$1$$anonfun$1$$anonfun$1(Execution.scala:223)
[09960] [error] scala.concurrent.impl.Promise$Transformation.run(Promise.scala:467)
[09960] [error] mill.exec.ExecutionContexts$.execute$$anonfun$1$$anonfun$2$$anonfun$1(ExecutionContexts.scala:65)
[09960] [error] mill.exec.ExecutionContexts$.mill$exec$ExecutionContexts$ThreadPool$$_$execute$$anonfun$1$$anonfun$2$$anonfun$adapted$1(ExecutionContexts.scala:66)
[09960] [error] mill.api.SystemStreamsUtils$.withStreams$$anonfun$1$$anonfun$1$$anonfun$1$$anonfun$1$$anonfun$1$$anonfun$1$$anonfun$1(SystemStreamsUtils.scala:49)
[09960] [error] scala.util.DynamicVariable.withValue(DynamicVariable.scala:59)
[09960] [error] mill.api.SystemStreamsUtils$.withStreams$$anonfun$1$$anonfun$1$$anonfun$1$$anonfun$1$$anonfun$1$$anonfun$1(SystemStreamsUtils.scala:50)
[09960] [error] scala.util.DynamicVariable.withValue(DynamicVariable.scala:59)
[09960] [error] mill.api.SystemStreamsUtils$.withStreams$$anonfun$1$$anonfun$1$$anonfun$1$$anonfun$1$$anonfun$1(SystemStreamsUtils.scala:51)
[09960] [error] scala.util.DynamicVariable.withValue(DynamicVariable.scala:59)
[09960] [error] mill.api.SystemStreamsUtils$.withStreams$$anonfun$1$$anonfun$1$$anonfun$1$$anonfun$1(SystemStreamsUtils.scala:52)
[09960] [error] scala.util.DynamicVariable.withValue(DynamicVariable.scala:59)
[09960] [error] scala.Console$.withErr(Console.scala:193)
[09960] [error] mill.api.SystemStreamsUtils$.withStreams$$anonfun$1$$anonfun$1$$anonfun$1(SystemStreamsUtils.scala:53)
[09960] [error] scala.util.DynamicVariable.withValue(DynamicVariable.scala:59)
[09960] [error] scala.Console$.withOut(Console.scala:164)
[09960] [error] mill.api.SystemStreamsUtils$.withStreams$$anonfun$1$$anonfun$1(SystemStreamsUtils.scala:54)
[09960] [error] scala.util.DynamicVariable.withValue(DynamicVariable.scala:59)
[09960] [error] scala.Console$.withIn(Console.scala:227)
[09960] [error] mill.api.SystemStreamsUtils$.withStreams$$anonfun$1(SystemStreamsUtils.scala:55)
[09960] [error] scala.util.DynamicVariable.withValue(DynamicVariable.scala:59)
[09960] [error] mill.api.SystemStreamsUtils$.withStreams(SystemStreamsUtils.scala:56)
[09960] [error] mill.exec.ExecutionContexts$ThreadPool.execute$$anonfun$1$$anonfun$2(ExecutionContexts.scala:66)
[09960] [error] mill.exec.ExecutionContexts$ThreadPool.execute$$anonfun$1$$anonfun$adapted$1(ExecutionContexts.scala:67)
[09960] [error] scala.util.DynamicVariable.withValue(DynamicVariable.scala:59)
[09960] [error] mill.exec.ExecutionContexts$ThreadPool.execute$$anonfun$1(ExecutionContexts.scala:67)
[09960] [error] mill.exec.ExecutionContexts$ThreadPool$PriorityRunnable.run(ExecutionContexts.scala:86)
[09960] [error] java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
[09960] [error] java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
[09960] [error] java.base/java.lang.Thread.run(Thread.java:833)
[09960] [error]            

[lihaoyi]

CC @ajaychandran if you are able to take a look at this

[lihaoyi]

Seems like def jvmId is only generated on the trait when --base-module is passed, and otherwise isn't generated directly on the module objects

[ajaychandran]

Seems like def jvmId is only generated on the trait when --base-module is passed, and otherwise isn't generated directly on the module objects

Yes, that is a limitation of the current design. This is true for Gradle and SBT imports as well.

This can be rectified as part of #5428.
Your suggestion for auto-detecting the jvmId is also worth considering though the feasibility will have to be explored. IIRC, some Gradle projects wouldn't even load without the correct JVM.