Skip to content

Conversation

@cchrischen
Copy link
Collaborator

@cchrischen cchrischen commented Aug 18, 2025

Summary

Copy pull from idol and pull from idol images scripts to the new website. Updated the workflows and scripts to use the new directory new-dti-website-redesign/public/team/teamHeadshots.

Test Plan

The generated PRs. #1017 #1018

Notes

I had to add back the images from those that I removed from IDOL manually. When removing someone from IDOL, it also removes their image in Firebase. Adding a backlog ticket to resolve this issue.

@cchrischen cchrischen requested a review from a team as a code owner August 18, 2025 02:19
@dti-github-bot
Copy link
Member

dti-github-bot commented Aug 18, 2025

[diff-counting] Significant lines: 137.

Copy link
Collaborator

@clementroze clementroze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating!

this is probably a question for later but we currently have new-dti-website and new-dti-website-redesign and iirc there was a third dti-website somewhere?

Do u know if one day we'll archive the previous versions and just rename whatever the current one is to just like smth simple like dti-website?

@cchrischen
Copy link
Collaborator Author

thanks for updating!

this is probably a question for later but we currently have new-dti-website and new-dti-website-redesign and iirc there was a third dti-website somewhere?

Do u know if one day we'll archive the previous versions and just rename whatever the current one is to just like smth simple like dti-website?

I deleted the two other website repos in a recent PR #987. Good callout. We can definitely and should do this in a follow up PR. In that PR, we could also clean up unused files and make project structure consisteny, e.g. where .jsons are stored.

@clementroze
Copy link
Collaborator

clementroze commented Aug 18, 2025

I deleted the two other website repos in a recent PR #987. Good callout. We can definitely and should do this in a follow up PR. In that PR, we could also clean up unused files and make project structure consisteny, e.g. where .jsons are stored.

Sounds good! And yes i agree for the json consistency – sometimes we're using a master config.json, but individual folders (eg course/data has a config.json) also contain one too.

Naming as well: seometimes we use hyphens (all-members.json), camelCase (roleIcons.json), or underscores (timeline_events.json)

@cchrischen cchrischen merged commit d96ecb3 into main Aug 18, 2025
7 checks passed
@cchrischen cchrischen deleted the cc/add-scripts-new-website branch August 18, 2025 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants