Consumer genesis encoding

[tbruyelle]

When the consumer module decodes its genesis data into the GenesisState struct, it uses the SDK JSONCodec :

interchain-security/x/ccv/consumer/module.go

Lines 112 to 118 in f23cbbb

	// InitGenesis performs genesis initialization for the consumer module. It returns
	// no validator updates.
	func (am AppModule) InitGenesis(ctx sdk.Context, cdc codec.JSONCodec, data json.RawMessage) []abci.ValidatorUpdate {
	var genesisState ccvtypes.GenesisState
	cdc.MustUnmarshalJSON(data, &genesisState)
	return am.keeper.InitGenesis(ctx, &genesisState)
	}

I found that problematic because it's not compatible with the encoding used by cometbft/types.GenDoc.SaveAs(), which uses the stdlib json encoding format.

Typical incompatibility for instance : time.Duration is encoded in string with SDK JSONCodec, while it is an integer with stdlib JSON.

That means a genesis file saved with GenDoc.SaveAs() will trigger a panic during the InitGenesis of the consumer module, because of that. (error is json: cannot unmarshal number into Go value of type string).

Do you think also it is a problem ?

[tbruyelle]

Closing because I realize my point isn't correct :

GenDoc.AppState is of type json.RawMessage, so actually GenDoc.SaveAs() has no impact on how the appState is encoded, because it is already raw data. What I need to fix on my side is how I encode the consumer app state before feeding the GenDoc.AppState.