-
Notifications
You must be signed in to change notification settings - Fork 31
Closed
Description
Sometimes there is no time to start a crate instance, as seen in https://github.com/crate/crate-python/actions/runs/18274076576/job/52022080415
with error:
Set up crate.testing.layer.crate Traceback (most recent call last):
File "/Users/runner/work/crate-python/crate-python/.venv/lib/python3.12/site-packages/zope/testrunner/runner.py", line 488, in run_layer
setup_layer(options, layer, setup_layers)
File "/Users/runner/work/crate-python/crate-python/.venv/lib/python3.12/site-packages/zope/testrunner/runner.py", line 858, in setup_layer
layer.setUp()
File "/Users/runner/work/crate-python/crate-python/src/crate/testing/layer.py", line 325, in setUp
self.start()
File "/Users/runner/work/crate-python/crate-python/src/crate/testing/layer.py", line 358, in start
self._wait_for_start()
File "/Users/runner/work/crate-python/crate-python/src/crate/testing/layer.py", line 413, in _wait_for_start
self._wait_for(validator)
File "/Users/runner/work/crate-python/crate-python/src/crate/testing/layer.py", line 394, in _wait_for
raise SystemError("Failed to start Crate instance in time.")
SystemError: Failed to start Crate instance in time.
These errors are getting more common, we should increase the default 30s
wait time and in the near future maybe try implementing testcontainer-python
to the test layer, in some cases I see we spun up many Crate instances, maybe we could re-use containers to only spun up one container and make tests run faster.
Metadata
Metadata
Assignees
Labels
No labels