Skip to content

Curve events are an utter mess #177

@kaber2

Description

@kaber2

Curve events are just a horrible mess without:

  • Some of the liquidity events return fixed sized arrays, meaning there is a different signature for each amount of tokens
  • RemoveLiquidityOne is missing the vital information, which coin was actually removed

So the first one, though butt-ugly, can be handled by just subscribing to all possible pool sizes. The second one can be handled as well, but even more uglier, since it requires any consumer that wishes to keep track of balances, to calculate the amount for all possible tokens to determine which one an event referred to. This of course requires to know the internal parameters of the pool, and:

  • There no pair creation or other initial event containing pool creation parameters

Sigh

Seriously, who "designed" such a mess? Given that basically every pool is incompatible in some way with the next one, to the extent that not even the pool registry is able to query a good proportion of them without reverting, how about just fixing this crap? Its not like ABI compatibility is an issue here...

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions