Skip to content

Update commands, playbooks, and terminology #40621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: contrib/jthom-vmray_consistent-package-naming-1
Choose a base branch
from

Conversation

jthom-vmray
Copy link
Contributor

@jthom-vmray jthom-vmray commented Jul 16, 2025

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Description

This PR enhances playbook logic to process IOCs from child submissions and introduces the new vmray-get-pdf-report command. It also fixes the output for the vmray-get-sample command and standardizes the vendor name and verdict terminology for better platform consistency.

Must have

  • Tests
  • Documentation

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack labels Jul 16, 2025
@content-bot content-bot changed the base branch from master to contrib/jthom-vmray_consistent-package-naming-1 July 16, 2025 12:53
@content-bot content-bot requested a review from merit-maita July 16, 2025 12:53
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @merit-maita will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Hi @jthom-vmray, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

Copy link
Contributor

@merit-maita merit-maita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for your contribution
i added a couple of comments, please take a look. More to that, some validations are failing in the pre-commit step, please take a look.
since it's a small update, can you record a demo video of the new command

sample_id = demisto.args().get("sample_id")
check_id(sample_id)

pdf_report = get_pdf_report(sample_id)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the search returns nothing (not found) you should return a readable stating that the item is not found and not to return an error. please verify this case

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already done in the http_request function. I returns a readable error message if anything goes wrong.

@@ -128,7 +128,7 @@ def test_dbot_score_by_hash():
"Reliability": "C - Fairly reliable",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a unit test to the new command

@merit-maita
Copy link
Contributor

@Benimanela can you review the changed playbooks please?

@CLAassistant
Copy link

CLAassistant commented Jul 17, 2025

CLA assistant check
All committers have signed the CLA.

@jthom-vmray jthom-vmray force-pushed the consistent-package-naming branch from 59fc744 to cb4e4ae Compare July 17, 2025 15:15
@jthom-vmray jthom-vmray force-pushed the consistent-package-naming branch from cb4e4ae to 49f74d5 Compare July 18, 2025 07:07
@jthom-vmray
Copy link
Contributor Author

Updated the contribution registration form to include a video link demonstrating the new command.

@merit-maita
Copy link
Contributor

@Benimanela can you take a look please?

@merit-maita
Copy link
Contributor

im getting this when trying to open the video
Screenshot 2025-07-20 at 11 26 11

@merit-maita merit-maita added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Jul 20, 2025
@content-bot
Copy link
Collaborator

For the Reviewer: Trigger build request has been accepted for this contribution PR.

@content-bot
Copy link
Collaborator

For the Reviewer: Successfully created a pipeline in GitLab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/4226196

@content-bot content-bot removed the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Jul 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack Partner Partner-Approved Security Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants