-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Update commands, playbooks, and terminology #40621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: contrib/jthom-vmray_consistent-package-naming-1
Are you sure you want to change the base?
Update commands, playbooks, and terminology #40621
Conversation
increment app version
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @merit-maita will know the proposed changes are ready to be reviewed. |
Hi @jthom-vmray, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for your contribution
i added a couple of comments, please take a look. More to that, some validations are failing in the pre-commit step, please take a look.
since it's a small update, can you record a demo video of the new command
sample_id = demisto.args().get("sample_id") | ||
check_id(sample_id) | ||
|
||
pdf_report = get_pdf_report(sample_id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the search returns nothing (not found) you should return a readable stating that the item is not found and not to return an error. please verify this case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already done in the http_request
function. I returns a readable error message if anything goes wrong.
@@ -128,7 +128,7 @@ def test_dbot_score_by_hash(): | |||
"Reliability": "C - Fairly reliable", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a unit test to the new command
@Benimanela can you review the changed playbooks please? |
59fc744
to
cb4e4ae
Compare
cb4e4ae
to
49f74d5
Compare
Updated the contribution registration form to include a video link demonstrating the new command. |
@Benimanela can you take a look please? |
For the Reviewer: Trigger build request has been accepted for this contribution PR. |
For the Reviewer: Successfully created a pipeline in GitLab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/4226196 |
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Description
This PR enhances playbook logic to process IOCs from child submissions and introduces the new vmray-get-pdf-report command. It also fixes the output for the vmray-get-sample command and standardizes the vendor name and verdict terminology for better platform consistency.
Must have