Open
Description
Potential area of improvement
As discussed in #3 (comment), the tup
function below is used to parse a string of two integers separated by a comma.
diffpy.nmf_mapping/diffpy/nmf_mapping/nmf_mapping/main.py
Lines 36 to 44 in 57eb972
tup
is used as an input to the parser.add_argument
function shown below:
diffpy.nmf_mapping/diffpy/nmf_mapping/nmf_mapping/main.py
Lines 100 to 107 in 57eb972
Suggestion
Recommended by @sbillinge , instead of creating a separate nested function called tup
, we shall use argparse
to parse the input more gracefully. I am currently not so familiar with the argparse
library at the moment. Once we are done with the cookiecutting release process, we can re-visit this problem.
Metadata
Metadata
Assignees
Labels
No labels