Sync from Azure DevOps: release/dev17.13 #18740
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update nuget handling in fsi ---- #### AI description (iteration 1) #### PR Classification New feature #### PR Summary This pull request updates the handling of NuGet packages in FSI, adding new features and improving existing functionality. - `vsintegration/src/FSharp.Editor/Common/Extensions.fs`: Added `TextViewEventsHandler` and methods to handle text view events and caret position. - `vsintegration/src/FSharp.Editor/LanguageService/FSharpProjectOptionsManager.fs`: Enhanced project options management with event subscriptions for caret and focus changes. - `src/Compiler/Driver/ScriptClosure.fs`: Improved package manager handling with editor cursor awareness. - `src/FSharp.DependencyManager.Nuget/FSharp.DependencyManager.fs`: Added support for `usepackagetargets` option in NuGet package references. - `tests/FSharp.Compiler.Private.Scripting.UnitTests/FSharpScriptTests.fs`: Added tests for `usepackagetargets` option in script evaluation. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
remove the need for loc strings ---- #### AI description (iteration 1) #### PR Classification Code cleanup #### PR Summary This pull request cleans up localization files and refines error handling for boolean values. - Removed `invalidBooleanValue` translations from multiple `.xlf` files. - Updated error message for invalid boolean values in `FSharp.DependencyManager.fs`. - Adjusted unit tests in `FSharpScriptTests.fs` to reflect the new error message format. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
normalize format
…es. -release/dev17.13 #### AI description (iteration 1) #### PR Classification Bug fix to prevent unnecessary package downloads. #### PR Summary This pull request addresses issue #18231 by fixing the logic that downloads unneeded packages in the NuGet dependency manager. - `FSharpProjectOptionsManager.fs`: Refactored to correctly handle text view and caret position retrieval. - `ScriptClosure.fs`: Simplified filtering of package manager lines. - `FSharp.DependencyManager.fs`: Streamlined error message handling for `usepackagetargets`. - `FSharpScriptTests.fs`: Adjusted test assertions to normalize error messages across different frameworks. - `Extensions.fs`: Fixed the parameter for `GetActiveView` to ensure correct view retrieval. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
#### AI description (iteration 1) #### PR Classification Compatibility update to ensure source build functionality with internal MSBuild version 17.13. #### PR Summary This pull request updates the build scripts and configuration files to maintain compatibility with internal MSBuild 17.13, ensuring smooth source build processes. - `eng/build.sh`: Added no-operation implementations for runtime arguments to support internal builds. - `eng/SourceBuildPrebuiltBaseline.xml`: Updated usage patterns to include new dependencies for MSBuild 17.13. - `azure-pipelines.yml`: Enabled internal source build parameters to facilitate source build processes. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
|
T-Gro
commented
Jul 9, 2025
abonie
approved these changes
Jul 9, 2025
T-Gro
added
the
NO_RELEASE_NOTES
|
/run fantomas |
🔧 CLI Command Report
✅ Patch applied: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR syncs commits from the internal Azure DevOps mirror for branch 'release/dev17.13'. Please review and merge.