From e97df98ec98b109eb6f7142d4fd34ad6e1e6002e Mon Sep 17 00:00:00 2001 From: Tom Meschter Date: Mon, 13 Nov 2023 13:37:48 -0800 Subject: [PATCH] Remove Microsoft.Net.Compilers.Toolset We've had a reference to this package for a long time even though it is only meant to be used to pick up hotfixes to the compiler before they make their way into an SDK update. We're not using it for that purpose; in general, moving to a new version of the SDK is the supported way of picking up a newer version of the compiler. And since we're not controlling the SDK version (we just use whatever is on the machine) we can't even guarantee that the package is in fact giving us a newer version. Here we remove the package entirely. This also exposes that there was some sort of issue running the PublicAPI analyzer on our VB projects when using the Microsoft.Net.Compilers.Toolset package, and the PublicAPI.Shipped.txt files have been updated with the correct contents. --- Directory.Packages.props | 1 - eng/imports/HostAgnostic.props | 1 - .../PublicAPI.Shipped.txt | 10 +++++- .../PublicAPI.Shipped.txt | 33 ------------------- 4 files changed, 9 insertions(+), 36 deletions(-) diff --git a/Directory.Packages.props b/Directory.Packages.props index c00d68567ea..5d49d65d102 100644 --- a/Directory.Packages.props +++ b/Directory.Packages.props @@ -80,7 +80,6 @@ - diff --git a/eng/imports/HostAgnostic.props b/eng/imports/HostAgnostic.props index e63137a6473..4010e14470d 100644 --- a/eng/imports/HostAgnostic.props +++ b/eng/imports/HostAgnostic.props @@ -12,7 +12,6 @@ -