Skip to content

Commit b46b9a1

Browse files
committed
Fixes Rider live test discovery see: https://youtrack.jetbrains.com/issue/RIDER-19912
By duplicating tests of base classes in intermediate base classes
1 parent f7e3262 commit b46b9a1

File tree

8 files changed

+27
-12
lines changed

8 files changed

+27
-12
lines changed

src/Tests/Tests.Core/Tests.Core.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
</PropertyGroup>
66
<ItemGroup>
77
<ProjectReference Include="..\Tests.Domain\Tests.Domain.csproj" />
8-
<PackageReference Include="Elastic.Xunit" Version="0.1.0-ci20180810T103700" />
8+
<PackageReference Include="Elastic.Xunit" Version="0.1.0-ci20180902T153954" />
99
<PackageReference Include="xunit" Version="2.3.1" />
1010
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.5.0" />
1111
<PackageReference Include="FluentAssertions" Version="4.19.2" />

src/Tests/Tests.Domain/Tests.Domain.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
</ItemGroup>
1313
<ItemGroup>
1414
<PackageReference Include="Bogus" Version="22.1.2" />
15-
<PackageReference Include="Elastic.Managed" Version="0.1.0-ci20180810T103700" />
15+
<PackageReference Include="Elastic.Managed" Version="0.1.0-ci20180902T153954" />
1616
<ProjectReference Include="..\Tests.Configuration\Tests.Configuration.csproj" />
1717
</ItemGroup>
1818
</Project>

src/Tests/Tests/Aggregations/AggregationUsageTestBase.cs

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
using Elasticsearch.Net;
1+
using System.Threading.Tasks;
2+
using Elastic.Xunit.XunitPlumbing;
3+
using Elasticsearch.Net;
24
using Nest;
35
using Tests.Core.Client;
46
using Tests.Core.ManagedElasticsearch.Clusters;
@@ -24,6 +26,13 @@ protected override LazyResponses ClientUsage() => Calls(
2426
requestAsync: (client, r) => client.SearchAsync<Project>(r)
2527
);
2628

29+
// Fixes Rider live test discovery see: https://youtrack.jetbrains.com/issue/RIDER-19912
30+
[I] public override Task HandlesStatusCode() => base.HandlesStatusCode();
31+
32+
[I] public override Task ReturnsExpectedIsValid() => base.ReturnsExpectedIsValid();
33+
34+
[I] public override Task ReturnsExpectedResponse() => base.ReturnsExpectedResponse();
35+
2736
protected override bool ExpectIsValid => true;
2837
protected override int ExpectStatusCode => 200;
2938
protected override HttpMethod HttpMethod => HttpMethod.POST;

src/Tests/Tests/Framework/EndpointTests/ApiIntegrationTestBase.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,13 +34,13 @@ protected ApiIntegrationTestBase(TCluster cluster, EndpointUsage usage) : base(c
3434

3535
protected override IElasticClient Client => this.Cluster.Client;
3636

37-
[I] public async Task HandlesStatusCode() =>
37+
[I] public async virtual Task HandlesStatusCode() =>
3838
await this.AssertOnAllResponses(r => r.ApiCall.HttpStatusCode.Should().Be(this.ExpectStatusCode));
3939

40-
[I] public async Task ReturnsExpectedIsValid() =>
40+
[I] public async virtual Task ReturnsExpectedIsValid() =>
4141
await this.AssertOnAllResponses(r => r.ShouldHaveExpectedIsValid(this.ExpectIsValid));
4242

43-
[I] public async Task ReturnsExpectedResponse() => await this.AssertOnAllResponses(ExpectResponse);
43+
[I] public async virtual Task ReturnsExpectedResponse() => await this.AssertOnAllResponses(ExpectResponse);
4444

4545
protected override Task AssertOnAllResponses(Action<TResponse> assert)
4646
{

src/Tests/Tests/IndexModules/UsageTestBase.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,12 @@ public abstract class UsageTestBase<TInterface, TDescriptor, TInitializer> : Exp
2020
protected UsageTestBase() : base(TestClient.DefaultInMemoryClient) =>
2121
this.FluentInstance = this.Fluent(new TDescriptor());
2222

23-
[U] protected void SerializesInitializer()
23+
[U] protected virtual void SerializesInitializer()
2424
{
2525
if (this.TestObjectInitializer) this.RoundTripsOrSerializes<TInterface>(this.Initializer);
2626
}
2727

28-
[U] protected void SerializesFluent() => this.RoundTripsOrSerializes(this.FluentInstance);
28+
[U] protected virtual void SerializesFluent() => this.RoundTripsOrSerializes(this.FluentInstance);
2929
}
3030

3131
public abstract class PromiseUsageTestBase<TInterface, TDescriptor, TInitializer> : ExpectJsonTestBase

src/Tests/Tests/Search/Request/PostFilterUsageTests.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,7 @@
55
using Nest;
66
using Tests.Core.ManagedElasticsearch.Clusters;
77
using Tests.Domain;
8-
using Tests.Framework;
98
using Tests.Framework.Integration;
10-
using Tests.Framework.ManagedElasticsearch.Clusters;
119

1210
namespace Tests.Search.Request
1311
{

src/Tests/Tests/Search/SearchUsageTestBase.cs

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
using Elasticsearch.Net;
1+
using System.Threading.Tasks;
2+
using Elastic.Xunit.XunitPlumbing;
3+
using Elasticsearch.Net;
24
using Nest;
35
using Tests.Core.ManagedElasticsearch.Clusters;
46
using Tests.Domain;
@@ -24,5 +26,12 @@ protected override LazyResponses ClientUsage() => Calls(
2426
protected override HttpMethod HttpMethod => HttpMethod.POST;
2527
protected override string UrlPath => "/project/project/_search";
2628

29+
// Fixes Rider live test discovery see: https://youtrack.jetbrains.com/issue/RIDER-19912
30+
[I] public override Task HandlesStatusCode() => base.HandlesStatusCode();
31+
32+
[I] public override Task ReturnsExpectedIsValid() => base.ReturnsExpectedIsValid();
33+
34+
[I] public override Task ReturnsExpectedResponse() => base.ReturnsExpectedResponse();
35+
2736
}
2837
}

src/Tests/Tests/XunitBootstrap.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
using Elastic.Xunit;
22
using Tests.Core.Xunit;
3-
using Tests.Framework.ManagedElasticsearch;
43

54
[assembly: Xunit.TestFrameworkAttribute("Elastic.Xunit.Sdk.ElasticTestFramework", "Elastic.Xunit")]
65
[assembly: ElasticXunitConfiguration(typeof(NestXunitRunOptions))]

0 commit comments

Comments
 (0)