From 9699a5725b67e8e75d42ef9ef6aa9d629719f95e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stanis=C5=82aw=20Pitucha?= Date: Wed, 3 Feb 2021 09:39:17 +1100 Subject: [PATCH] Make the compile time parameter error clearer Print out the expectation that the parameter should be under a specific key. --- .../sparkle_formation/compile_time/empty_validator.rb | 2 +- .../sparkle_formation/compile_time/empty_validator_spec.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/stack_master/sparkle_formation/compile_time/empty_validator.rb b/lib/stack_master/sparkle_formation/compile_time/empty_validator.rb index a8c85721..2dabf609 100644 --- a/lib/stack_master/sparkle_formation/compile_time/empty_validator.rb +++ b/lib/stack_master/sparkle_formation/compile_time/empty_validator.rb @@ -23,7 +23,7 @@ def has_invalid_values? end def create_error - "#{@name} cannot contain empty parameters:#{@parameter.inspect}" + "#{@name} is not present inside the 'compile_time_parameters' entry, or has an empty value; found: #{@parameter.inspect}" end end diff --git a/spec/stack_master/sparkle_formation/compile_time/empty_validator_spec.rb b/spec/stack_master/sparkle_formation/compile_time/empty_validator_spec.rb index 453b4bf3..62c7a3b4 100644 --- a/spec/stack_master/sparkle_formation/compile_time/empty_validator_spec.rb +++ b/spec/stack_master/sparkle_formation/compile_time/empty_validator_spec.rb @@ -2,7 +2,7 @@ describe '#validate' do let(:name) { 'name' } - let(:error_message) { -> (error, _definition) { "#{name} cannot contain empty parameters:#{error.inspect}" } } + let(:error_message) { -> (error, _definition) { "#{name} is not present inside the 'compile_time_parameters' entry, or has an empty value; found: #{error.inspect}" } } context 'string validation' do let(:definition) { {type: :string} }