Pyright diagnosticMode: "workspace" equivalent in Pyrefly

[Pristor]

Describe the Bug

Pyright has the following configurable settings when using it with an IDE like Zed, VSCode, etc.:

python.analysis.diagnosticMode [“openFilesOnly”, “workspace”]: Determines whether pyright analyzes (and reports errors for) all files in the workspace, as indicated by the config file. If this option is set to “openFilesOnly”, pyright analyzes only open files.

Currently, it appears that Pyrefly only supports the "openFilesOnly" diagnostic mode. Given the speed of Pyrefly, I believe it would make sense to implement support for the "workspace" mode as well.

Sandbox Link

No response

(Only applicable for extension issues) IDE Information

No response

[lolpack]

cc @SamChou19815

[SamChou19815]

We do have the ability to emit all errors for a given projects. These errors are actually tracked within the LSP server, but we didn't emit them now, because we still have many type system gaps we need to close. I found that if we enable it for a large internal project, it will emit so many errors that it will freeze VSCode. That being said, we could gate it behind a flag for now.

[Pristor]

Pyright’s default behavior is the same; it needs to be explicitly set to “workspace” to work that way. Personally, I like having the option to emit all errors for medium-sized or completely new projects.

[lolpack]

@SamChou19815 @kinto0 should this be a configurable option so developers can test the functionality? It sounds like we are going to make it configurable in the future anyways, so allowing it to be turned on now could be nice for some developers.

[kinto0]

@SamChou19815 @kinto0 should this be a configurable option so developers can test the functionality? It sounds like we are going to make it configurable in the future anyways, so allowing it to be turned on now could be nice for some developers.

yes. this setting should be added. @connernilsen do you think it should be part of an on-disk configuration too? I imagine certain projects will want to enable / disable it.

[connernilsen]

@kinto0 like configuring the IDE in an on-disk config? If so, we can probably do that pretty easily. I could see it being confusing for users though, since changing that setting in the IDE won't do anything if it's set in the config file

[kinto0]

@kinto0 like configuring the IDE in an on-disk config? If so, we can probably do that pretty easily. I could see it being confusing for users though, since changing that setting in the IDE won't do anything if it's set in the config file

IDE setting should still override the config setting

[connernilsen]

Oh in that case I think it's probably something that shouldn't be added to the config file.

IDE-specific settings most shouldn't be added to a config file in most cases, especially if they're overridable in IDE.

Offline @kinto0 and I spoke about allowing the IDE to override config file options. We need to talk about it more, but it could be a good idea in the future