Open
Description
I was able to add rough support for Mac icon sizes by modifying appicon/actions/appicon_action.rb
to include the Mac dimensions, like this:
def self.needed_icons
{
iphone: {
'2x' => ['20x20', '29x29', '40x40', '60x60'],
'3x' => ['20x20', '29x29', '40x40', '60x60']
},
ipad: {
'1x' => ['20x20', '29x29', '40x40', '76x76'],
'2x' => ['20x20', '29x29', '40x40', '76x76', '83.5x83.5']
},
mac: {
'1x' => ['16x16', '32x32', '128x128', '256x256', '512x512'],
'2x' => ['16x16', '32x32', '128x128', '256x256', '512x512']
},
}
end
This worked for my purposes. I would submit a PR, however this isn't completely correct. Because of the double array loop where the resizing occurs, the script also writes out the iphone
and ipad
sizes, resulting in some Unassigned
/ unknown-trait-combination
entries in the resulting xcassets file. A better solution would be to not export he iphone
and ipad
sizes for the mac
device. I don't know enough about how necessary these are for the other devices to make the change myself.