Implement dir and dirxml command

[janodvarko]

The command line should offer the dir() and dirxml() commands.

Platform API: search for "JSTermHelpers"

Honza

[fflorent]

They probably can be aliased to console.dir[xml], which are existant in the DevTools.

I am taking this one, as it is probably the simplest to implement, and it would introduce the registration logic. Thus it would pave the way for the other commands and maybe for some Firebug SDK methods.

Florent

[fflorent]

Above is the work in progress. Some comments/questions:

1. dirxml won't do anything. Because console.dirxml() is not implemented yet. See bug 922212
2. dir works in when not using E10S. When using E10S, you need to (otherwise, dir is not defined, and I don't know why):
   1. open a new tab
   2. close the previous tab
   3. Open the DevTools and run dir(whatEverYouWant)
3. As explained here, I don't know what to choose between a tab or a global actor (I would say global ; thoughts?). But choosing a global actor doesn't work with E10S. Any idea why?

Florent

[fflorent]

@janodvarko Could you give me some feedback please (especially for point 2 and 3 of the previous comment)?

Thanks in advance

Florent

[fflorent]

ping @janodvarko ?

Florent

[janodvarko]

@fflorent: sorry for the delay

add 2) dir works in when not using E10S. When using E10S, you need to (otherwise, dir is not defined, and I don't know why):

This might be related to https://bugzilla.mozilla.org/show_bug.cgi?id=1155168
I attached a platform patch, so you might want to try it out and see if it helps.

add 3) As explained here, I don't know what to choose between a tab or a global actor

If I understand correctly your commands are using the current window

owner.window.console.dir(...args);

so, you need to run in the child process (the same process as the tab/window), so Tab actor is the right choice here.

Honza

[fflorent]

This might be related to https://bugzilla.mozilla.org/show_bug.cgi?id=1155168
I attached a platform patch, so you might want to try it out and see if it helps.

Weird, I can't tell why, but I can't reproduce the issue, even without the patch. Let's say it works.....

so, you need to run in the child process (the same process as the tab/window), so Tab actor is the right choice here.

Thanks for the explanation.

So I guess the patch is ready for a review.

Florent

[janodvarko]

So I guess the patch is ready for a review.

I did couple of comments.
I think that you can commit as soon as it's resolved.

Honza