Skip to content

Commit a055a1c

Browse files
authored
Merge pull request #185 from richm/update-to-2.3.0
use kubeclient 4.4.latest; refactor tests for k8s api discovery
2 parents ce981b4 + 898b193 commit a055a1c

16 files changed

+615
-1110
lines changed

fluent-plugin-kubernetes_metadata_filter.gemspec

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
44

55
Gem::Specification.new do |gem|
66
gem.name = "fluent-plugin-kubernetes_metadata_filter"
7-
gem.version = "2.2.0"
7+
gem.version = "2.3.0"
88
gem.authors = ["Jimmi Dyson"]
99
gem.email = ["[email protected]"]
1010
gem.description = %q{Filter plugin to add Kubernetes metadata}
@@ -21,7 +21,7 @@ Gem::Specification.new do |gem|
2121

2222
gem.add_runtime_dependency 'fluentd', ['>= 0.14.0', '< 2']
2323
gem.add_runtime_dependency "lru_redux"
24-
gem.add_runtime_dependency "kubeclient", "~> 1.1.4"
24+
gem.add_runtime_dependency "kubeclient", '< 5'
2525

2626
gem.add_development_dependency "bundler", "~> 1.3"
2727
gem.add_development_dependency "rake"

lib/fluent/plugin/filter_kubernetes_metadata.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ def fetch_namespace_metadata(namespace_name)
136136
metadata = parse_namespace_metadata(metadata)
137137
@stats.bump(:namespace_cache_api_updates)
138138
log.trace("parsed metadata for #{namespace_name}: #{metadata}") if log.trace?
139-
@namespace_cache[metadata['namespace_id']] = metadata
139+
@namespace_cache[metadata['namespace_id']] = metadata
140140
return metadata
141141
rescue Exception => e
142142
log.debug(e)
@@ -164,7 +164,6 @@ def log.trace?
164164
end
165165

166166
require 'kubeclient'
167-
require 'active_support/core_ext/object/blank'
168167
require 'lru_redux'
169168
@stats = KubernetesMetadata::Stats.new
170169

lib/fluent/plugin/kubernetes_metadata_common.rb

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,3 +111,29 @@ def syms_to_strs(hsh)
111111

112112
end
113113
end
114+
115+
# copied from activesupport
116+
class Object
117+
# An object is blank if it's false, empty, or a whitespace string.
118+
# For example, +nil+, '', ' ', [], {}, and +false+ are all blank.
119+
#
120+
# This simplifies
121+
#
122+
# !address || address.empty?
123+
#
124+
# to
125+
#
126+
# address.blank?
127+
#
128+
# @return [true, false]
129+
def blank?
130+
respond_to?(:empty?) ? !!empty? : !self
131+
end
132+
133+
# An object is present if it's not blank.
134+
#
135+
# @return [true, false]
136+
def present?
137+
!blank?
138+
end
139+
end

test/cassettes/kubernetes_docker_metadata_annotations.yml

Lines changed: 0 additions & 34 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/cassettes/kubernetes_docker_metadata_dotted_labels.yml

Lines changed: 0 additions & 34 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/cassettes/kubernetes_get_api_v1.yml

Lines changed: 193 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)