Fix back-key handling #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swift-kim
reviewed
Jul 4, 2025
The backkey performs the function of going back the prev-page(Navigator) by calling popRoute when pressed. This is because the back key is a system-level key and other platforms behave the same. however, in the dialog case of flutter, there is a case where navigator.pop() is occured on key-down. Therefore, when the key-down event is handled for the Back key, the up event is also ‘handled’.
JSUYA
force-pushed
the
fix_backkey_handling
branch
from
9f882b5 to
7d02ba2
Compare
seungsoo47
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The backkey performs the function of going back the prev-page(Navigator) by calling popRoute when pressed.
This is because the back key is a system-level key and other platforms behave the same.
however, in the dialog case of flutter, there is a case where navigator.pop() is occured on key-down.
Therefore, when the key-down event is handled for the Back key, the up event is also ‘handled’.
related issue: #106