Skip to content

Commit a073719

Browse files
authored
BREAKING (potentially) - Bump docker version (Ubuntu 22.04 LTS) (#556)
* fix: resolution errors and vulnerability * feat: bump (major) docker image rolling tag * chore: bump major version * fix: up workflow node to lts * fix: conventions
1 parent ff551fe commit a073719

File tree

13 files changed

+95721
-74428
lines changed

13 files changed

+95721
-74428
lines changed

.eslintrc.json

Lines changed: 50 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,22 @@
11
{
2-
"plugins": ["jest", "@typescript-eslint", "prettier", "unicorn"],
3-
"extends": ["plugin:unicorn/recommended", "plugin:github/recommended", "plugin:prettier/recommended"],
2+
"plugins": [
3+
"jest",
4+
"@typescript-eslint",
5+
"prettier",
6+
"unicorn"
7+
],
8+
"extends": [
9+
"plugin:unicorn/recommended",
10+
"plugin:github/recommended",
11+
"plugin:prettier/recommended"
12+
],
413
"parser": "@typescript-eslint/parser",
514
"parserOptions": {
615
"ecmaVersion": 2020,
716
"sourceType": "module",
8-
"extraFileExtensions": [".mjs"],
17+
"extraFileExtensions": [
18+
".mjs"
19+
],
920
"ecmaFeatures": {
1021
"impliedStrict": true
1122
},
@@ -22,7 +33,10 @@
2233
// Namespaces or sometimes needed
2334
"import/no-namespace": "off",
2435
// Properly format comments
25-
"spaced-comment": ["error", "always"],
36+
"spaced-comment": [
37+
"error",
38+
"always"
39+
],
2640
"lines-around-comment": [
2741
"error",
2842
{
@@ -38,23 +52,49 @@
3852
// Mandatory spacing
3953
"padding-line-between-statements": [
4054
"error",
41-
{ "blankLine": "always", "prev": "*", "next": "return" },
42-
{ "blankLine": "always", "prev": "directive", "next": "*" },
43-
{ "blankLine": "any", "prev": "directive", "next": "directive" }
55+
{
56+
"blankLine": "always",
57+
"prev": "*",
58+
"next": "return"
59+
},
60+
{
61+
"blankLine": "always",
62+
"prev": "directive",
63+
"next": "*"
64+
},
65+
{
66+
"blankLine": "any",
67+
"prev": "directive",
68+
"next": "directive"
69+
}
4470
],
4571
// Enforce camelCase
4672
"camelcase": "error",
4773
// Allow forOfStatements
48-
"no-restricted-syntax": ["error", "ForInStatement", "LabeledStatement", "WithStatement"],
74+
"no-restricted-syntax": [
75+
"error",
76+
"ForInStatement",
77+
"LabeledStatement",
78+
"WithStatement"
79+
],
4980
// Continue is viable in forOf loops in generators
5081
"no-continue": "off",
5182
// From experience, named exports are almost always desired. I got tired of this rule
5283
"import/prefer-default-export": "off",
5384
// Unused vars are useful to keep method signatures consistent and documented
5485
"@typescript-eslint/no-unused-vars": "off",
5586
// For this project only use kebab-case
56-
"unicorn/filename-case": ["error", { "cases": { "kebabCase": true } }],
87+
"unicorn/filename-case": [
88+
"error",
89+
{
90+
"cases": {
91+
"kebabCase": true
92+
}
93+
}
94+
],
5795
// Allow Array.from(set) mitigate TS2569 which would require '--downlevelIteration'
58-
"unicorn/prefer-spread": "off"
96+
"unicorn/prefer-spread": "off",
97+
// Temp disable to prevent mixing changes with other PRs
98+
"i18n-text/no-en": "off"
5999
}
60100
}

.github/workflows/cleanup.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
lfs: true
2222
- uses: actions/setup-node@v3
2323
with:
24-
node-version: 16.x
24+
node-version: '18'
2525
- run: yarn
2626
- run: yarn run cli --help
2727
env:

.github/workflows/integrity-check.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
- uses: actions/checkout@v3
2020
- uses: actions/setup-node@v3
2121
with:
22-
node-version: '16'
22+
node-version: '18'
2323
- run: yarn
2424
- run: yarn lint
2525
- run: yarn test --coverage

0 commit comments

Comments
 (0)