Don't expect return value from API.patch_set

The XML-RPC API returns True if a patch update is successful else it
raises an exception. The REST API returns an updated copy of the patch
if successful else it returns a HTTP 4xx error. These different return
styles meant we couldn't effectively return a value from the 'patch_set'
API method in the success case, only raise an exception in the failure
case. We addressed this in commit 0949e9e but forgot to update callers
than were checking for a success return value. Do this now.

Signed-off-by: Stephen Finucane <[email protected]>
Fixes: 0949e9e ("api: More signature corrections")
Closes: #23

Author: stephenfin

pwclient/patches.py

@@ -225,16 +225,13 @@ def action_update(api, patch_id, state=None, archived=None, commit_ref=None):
         print(str(exc), file=sys.stderr)
         sys.exit(1)
 
-    success = False
     try:
-        success = api.patch_set(
+        api.patch_set(
             patch_id,
             state=state,
             archived=archived,
             commit_ref=commit_ref,
         )
     except Exception as exc:
         print(str(exc), file=sys.stderr)
-
-    if not success:
-        print('Patch not updated', file=sys.stderr)
+        sys.exit(1)

tests/test_patches.py

@@ -519,7 +519,8 @@ def test_action_update__error(capsys):
     api.patch_get.return_value = fakes.fake_patches()[0]
     api.patch_set.side_effect = exceptions.APIError('foo')
 
-    patches.action_update(api, 1157169)
+    with pytest.raises(SystemExit):
+        patches.action_update(api, 1157169)
 
     api.patch_set.assert_called_once_with(
         1157169, archived=None, commit_ref=None, state=None
@@ -532,23 +533,5 @@ def test_action_update__error(capsys):
         captured.err
         == """\
 foo
-Patch not updated
 """
     )
-
-
-def test_action_update__no_updates(capsys):
-    api = mock.Mock()
-    api.patch_get.return_value = fakes.fake_patches()[0]
-    api.patch_set.return_value = None
-
-    patches.action_update(api, 1157169)
-
-    api.patch_set.assert_called_once_with(
-        1157169, archived=None, commit_ref=None, state=None
-    )
-
-    captured = capsys.readouterr()
-
-    assert captured.out == ''
-    assert captured.err == 'Patch not updated\n'