-
Notifications
You must be signed in to change notification settings - Fork 68
Open
Labels
priority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.
Description
This is a follow-up for #3851 to address some secondary code organization concerns discovered during PR review. Details are in the linked PR comments, but to summarize a few key points:
-
EndpointContext, GrpcChannelProvider, and HttpJsonChannelProvider each instantiate its own mTLS provider today using a similar but duplicated flow - this could potentially be refactored so that a single mTLS provider can be shared between EndpointContext and the Channel providers.
-
A related concern is to address is the nullability of "CertificateBasedAccess" helper in EndpointContext to make it non-Nullable without breaking existing tests.
Metadata
Metadata
Assignees
Labels
priority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.