-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Labels
Milestone
Description
Multiple of our CIs currently run with -PfailOnWarnings=true
. This is observed by our main build.gradle
to enable -Werror
:
Lines 39 to 41 in 9dec06c
if (rootProject.hasProperty('failOnWarnings') && rootProject.failOnWarnings.toBoolean()) { | |
it.options.compilerArgs += ["-Werror"] | |
} |
We should observe the property for Android as well. This will help keep our builds clean and prevent things like #6866.
Android also has a fair number of linter warnings. It would be nice if we got to a place where they were covered by -PfailOnWarnings=true
as well, but that could happen later (in which case we should create a new issue to track it).