You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
how to keep old build and only rebuild react-server-dom-vite?
# build common deps (see yarn build-for-flight-dev) (not necessary?)
node ./scripts/rollup/build.js react/index,react/jsx,react.react-server,react-dom/index,react-dom/client,react-dom/server,react-dom.react-server,react-dom-server.node,react-dom-server-legacy.node,scheduler type=NODE_DEV
# how to keep old builds?
node ./scripts/rollup/build.js react-server-dom-vite/ --type=NODE_DEV
# copy to fixture
cp -rf build/node_modules fixtures/flight-vite/node_modules
Which react-server-dom-xxx should we copy to start with?
probably react-server-dom-webpack or actually Jacob's manifest
How to actually implement "invalidate-able" async module?
start with Jacobs manifest API and provide default one?
maybe we can just stash (mutate) it in ClientReference?
about chunk preload
is server side reference module deps preload necessary?
actually there's no safe way to "preload" on server. running import(...) breaks execution order (since it's not a module factory chunk like webpack). so we cannot have server deps chunk preload.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
TODO
react-server-dom-vite?react-server-dom-xxxshould we copy to start with?react-server-dom-webpackor actually Jacob's manifestClientReference?import(...)breaks execution order (since it's not a module factory chunk like webpack). so we cannot have server deps chunk preload.hoistTransitiveImportsis safe only because it's entry? https://rollupjs.org/configuration-options/#output-hoisttransitiveimports__vitePreloadworks equivalently (and it's safe since it only usesmodulepreload), so we don't need that logic as well.resolveClientReferenceMetadataReactDOM.preloadModuleinstead of prepare destination logic.Can we have opinionated client/server references handling?
__vite_rsc_raw_import__on client to workaroundvirtual:vite-rsc/client-referencesandvirtual:vite-rsc/server-referencesvirtual:vite-rsc/client-referencesto include asset depsBeta Was this translation helpful? Give feedback.
All reactions