-
Notifications
You must be signed in to change notification settings - Fork 123
Description
Describe the bug
Since the Bitcoin chain behind Testnet is regtest, some of the addresses on the reward_slot_holders
page are not in the correct format (i.e. they are testnet addresses instead of regtest ones, even if the node processes them as regtest addresses).
Steps To Reproduce
For example, at block 54053, the 2 rewarded addresses according to the bitcoin chain were:
mgZ5KJFnXmSvdrPNR7eQGz2RUKeqBanpAM
bcrt1qxnzlc57krja4jzq6vq3fylll0rydxr2xst4erg
However, the reward_slot_holders endpoint shows one of the addresses as a testnet one (tb1qxnzlc57krja4jzq6vq3fylll0rydxr2xjzv55p
):
Going to the individual reward_slot_holders
for each address:
- mgZ5KJFnXmSvdrPNR7eQGz2RUKeqBanpAM - is being shown right
- tb1qxnzlc57krja4jzq6vq3fylll0rydxr2xjzv55p - the address does not exist on the bitcoin chain, however the reward slots received by
bcrt1qxnzlc57krja4jzq6vq3fylll0rydxr2xst4erg
appear here - bcrt1qxnzlc57krja4jzq6vq3fylll0rydxr2xst4erg - no reward slots shown, even though they were received
This example is relevant because tb1qxnzlc57krja4jzq6vq3fylll0rydxr2xjzv55p
and bcrt1qxnzlc57krja4jzq6vq3fylll0rydxr2xst4erg
contain the same version and hashbytes, but the first is on testnet while the last one is on regtest.
Expected behavior
The reward slot holders endpoint should show the slots received by tb1qxnzlc57krja4jzq6vq3fylll0rydxr2xjzv55p
under the bcrt1qxnzlc57krja4jzq6vq3fylll0rydxr2xst4erg
address instead.
Environment
Hosted API (https://api.testnet.hiro.so) and hosted bitcoin explorer (https://mempool.bitcoin.regtest.hiro.so)
Minor, Non-launch blocking bugs
Minor bugs
- Bugs in non-critical software (CLI, UI, etc) that doesn’t impact critical functionality