Merge pull request #83 from stof/patch-1

robocoder · web-flow · commit a9a3deea7e4e · 2017-11-29T11:25:43.000-05:00
Fix the BC layer for the legacy execute method
diff --git a/lib/WebDriver/Session.php b/lib/WebDriver/Session.php
@@ -455,16 +455,16 @@ public function alert()
 
     /**
      * script execution method chaining, e.g.,
-     * - $session->execute() - fallback for legacy JSON Wire Protocol
+     * - $session->execute($jsonScript) - fallback for legacy JSON Wire Protocol
      * - $session->execute()->method() - chaining
      *
      * @return mixed
      */
     public function execute()
     {
         // execute script
-        if (func_num_args() === 0) {
-            $result = $this->curl('POST', '/execute');
+        if (func_num_args() > 0) {
+            $result = $this->curl('POST', '/execute', func_get_arg(1));
 
             return $result['value'];
         }

Original file line number	Diff line number	Diff line change
`@@ -455,16 +455,16 @@ public function alert()`
`455`	`455`
`456`	`456`	`/**`
`457`	`457`	`* script execution method chaining, e.g.,`
`458`		`- * - $session->execute() - fallback for legacy JSON Wire Protocol`
	`458`	`+ * - $session->execute($jsonScript) - fallback for legacy JSON Wire Protocol`
`459`	`459`	`* - $session->execute()->method() - chaining`
`460`	`460`	`*`
`461`	`461`	`* @return mixed`
`462`	`462`	`*/`
`463`	`463`	`public function execute()`
`464`	`464`	`{`
`465`	`465`	`// execute script`
`466`		`- if (func_num_args() === 0) {`
`467`		`- $result = $this->curl('POST', '/execute');`
	`466`	`+ if (func_num_args() > 0) {`
	`467`	`+ $result = $this->curl('POST', '/execute', func_get_arg(1));`
`468`	`468`
`469`	`469`	`return $result['value'];`
`470`	`470`	`}`