-
Notifications
You must be signed in to change notification settings - Fork 88
Add games/rbdoom3bfg #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add games/rbdoom3bfg #184
Conversation
I updated the pull request a bit. Removed glslang, since the system one is used. |
games/rbdoom3bfg/Makefile
Outdated
|
||
CATEGORIES= games | ||
|
||
HOMEPAGE= https://www.moddb.com/mods/rbdoom-3-bfg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if that is good to use as a homepage... or rather delete the line and leave the default, which will be the GitHub repo...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed.
games/rbdoom3bfg/Makefile
Outdated
# c++17 | ||
COMPILER = base-clang ports-gcc | ||
|
||
# Set -DUSE_VULKAN=OFF to build OpenGL version of the game. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few systems that don't build or run Vulkan. I wonder if we should have 2 separate flavors?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about it too. It is better to have two ports. One with Vulkan support. The other OpenGL.
games/rbdoom3bfg/files/rbdoom3bfg.6
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you write this man page? I appreciate the effort, but feel this is something for upstream, not for the the port
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was written by Tobias Frost [email protected] for a deb package under GPL-2 or later. I'll just remove this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably also better to have upstream include this file rather than supplying it this way with the port. If this file isn't included upstream, the license may be unclear and could be an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed.
-project(RBDoom3BFG) | ||
+project(rbdoom3bfg) | ||
|
||
+include_directories(/usr/X11R6/include) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's cleaner and easier to maintain to add include directories in the port Makefile, which usually works with:
CXXFLAGS += ${X11BASE}/include
and depending on which compiler languages are used also:
CFLAGS += ${X11BASE}/include
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready.
I updated the pull request taking into account all the comments. Now I will send to ports@ and make a pull request for the Vulkan version. |
Hello!
This is a port of the game DOOM-3-BFG to OpenBSD.
This is the open source code of .RBDOOM-3-BFG. OpenGL version.
send to ports@ 2025-19-05
Tested on amd64 architecture on OpenBSD 7. 7 installed on real hardware:
ASUS TUF GAMING B450M-PRO II
AMD Ryzen 5 5600G
AMD Radeon RX 580 PowerColor.
(amdgpu)
Works as good as on Linux.
Video:
https://www.youtube.com/watch?v=7E5OFp_dHfA
https://www.youtube.com/watch?v=a0zuUrsbXCY
I want to add this to the official ports tree, so please
leave any feedback or suggestions on how to improve it. Thanks!
Source on Github:
https://github.com/RobertBeckebans/RBDOOM-3-BFG