extra_context in PIPELINE_CSS/JS is kind of misleading

[fabianbuechler]

I believe, the documentation for extra_context in the PIPELINE_CSS/JS packages is a bit misleading.

As I understood the documentation, all keys/values I assign to extra_context would be passed to the templates as a dictionary and be iterated over to include them all as attributes of the <script/link> tags.

The only attribute that works for is basically media for CSS links.

In my eyes, the desired behaviour would be to pass extra_context directly to the template, maybe except for the media key, and include all keys as attributes.
Currently, since extra_context is not passed to the template, but all the keys separately, one cannot even iterate over the keys but has to modify the templates for every attribute.

In our case, we'd like to use requre.js as a package and need to pass a "data-main" attribute, which requre.js uses to load other packages.

I guess there's a design decision to do here, so I did not implement anything yet. But if you are ok with this, I could write some code here. Please let me know what you think.

Cheers,
Fabian

[cyberdelia]

As it works now, extra_context is passed to the template and you can override the template to fit your needs by creating your own templates named pipeline/css.html and/or pipeline/js.html

Changing extra_context to something like attributes might be a good idea, as long as we provide sane defaults for missing attributes. We also need a way to provide complex css/js declarations which extra_context and templates allows.

[fabianbuechler]

When I check the template context using the debug toolbar, I see that extra_context is not passed to the templates, but rather every key-value pair separately.

pipeline/js.html
.../templates/pipeline/js.html

{'data_main': '/static/project/js/main',
 'url': '/static/project/js/require.js'}

That -- in my eyes -- makes it impossible to iterate over all the keys and add attributes at will, without having to modify the template for each.

For the required attributes, I'd pass them directly, exactly as it works now. If they are overwritten in extra_context, I'd remove the keys from extra_context before passing it to the template.