Check for meetingId conflicts #1233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bgrozev
commented
Jun 25, 2025
bgrozev
commented
- log: Remove meeting_id when resetting log context.
- chore: Update jitsi-xmpp-extensions.
- fix: Consider blank string from MUC form as unset meeting_id.
- chore: Fix warnings.
|
|
||
| ChatRoomInfo chatRoomInfo = chatRoom.join(); | ||
| if (chatRoomInfo.getMeetingId() == null) | ||
| if (org.apache.commons.lang3.StringUtils.isBlank(chatRoomInfo.getMeetingId())) |
There was a problem hiding this comment.
Can this not be imported?
| /** | ||
| * Selects a visitor node for a new participant, and joins the associated chat room if not already joined | ||
| * @return | ||
| * @return the ID of the selected node, or null if the endpoint is to be sent to the main room. |
There was a problem hiding this comment.
Annotate return type with @Nullable?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1233 +/- ##
============================================
- Coverage 26.45% 26.45% -0.01%
- Complexity 464 465 +1
============================================
Files 127 127
Lines 8410 8429 +19
Branches 1183 1185 +2
============================================
+ Hits 2225 2230 +5
- Misses 5889 5901 +12
- Partials 296 298 +2
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
| if (attempts >= 100) | ||
| if (!listener.meetingIdSet(this, meetingId)) | ||
| { | ||
| logger.error("Failed to set a unique meeting ID after 100 attempts, giving up."); |
There was a problem hiding this comment.
This is no longer doing 100 attempts, log should change
| } | ||
|
|
||
| String meetingId; | ||
| if (org.apache.commons.lang3.StringUtils.isBlank(chatRoomMeetingId)) |
| /** | ||
| * Fire an event attempting to set the meeting ID for the conference. The implementation should return `false` | ||
| * in case another meeting with the same ID already exists, which will result in a new randomly generated | ||
| * meeting ID to be attempted. |
There was a problem hiding this comment.
This comment should be changed now
JonathanLennox
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.