Banners - Alias

[brianteeman]

Steps to reproduce the issue

Create a banner called "test"
Try and create a second banner with the same name "test"

Expected result

The code suggests that it should not be possible to save the second banner as the alias is not unique

joomla-cms/administrator/components/com_banners/src/Table/BannerTable.php

Lines 264 to 271 in b2004e7

	// Verify that the alias is unique
	$table = new self($db, $this->getDispatcher());
	if ($table->load(['alias' => $this->alias, 'catid' => $this->catid]) && ($table->id != $this->id || $this->id == 0)) {
	$this->setError(Text::_('COM_BANNERS_ERROR_UNIQUE_ALIAS'));
	return false;
	}

Actual result

The banner is saved resulting in two banners in the same category with the same name and alias

Additional comments

Not even sure why banners have an alias at all

[chmst]

The check is not made for new banners, only at update. This is a bug.

Questions are:

Not even sure why banners have an alias at all

Is it allowed to have two banners with the same name in a category? I think yes, if at least the clients are different, there is no check for clients

[richard67]

Closing as having a pull request. Please test #45599 . Thanks in advance.