Skip to content

Change controller+worker taints label to node-role.kubernetes.io/control-plane #5810

Closed
@walf443

Description

@walf443

Is your feature request related to a problem? Please describe.

k0s taints "controler+worker" node as node-role.kubernetes.io/master by default.

The node label node-role.kubernetes.io/master was already deprecated. https://kubernetes.io/docs/reference/labels-annotations-taints/#node-role-kubernetes-io-master-taint

For workloads intended to run solely on control plane nodes, users often rely on the presence of this label. To better facilitate this use case, it would be beneficial I think if nodes designated as control plane nodes were automatically tainted with node-role.kubernetes.io/control-plane by default.

For example, I got this issue with topolvm scheduler settings: https://github.com/topolvm/topolvm/tree/main/charts/topolvm scheduler.affinity

Describe the solution you would like

Given that this change could potentially impact backward compatibility in long-running clusters, perhaps it would be more prudent to introduce it around v1.34.0+k0s or v1.35.0+k0s ? This would allow existing clusters more time to adapt.

Describe alternatives you've considered

No response

Additional context

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions