CORS breaking change

[y-kawawa]

Thank you for adding echo support.
After pulling the latest master, I noticed the following:

#2732 introduces a breaking change.
Since CORS checks are ultimately enforced by the browser, I think it would be helpful to provide an option that preserves backward compatibility.

One more point. I’d like to work with a release cut from the latest master.
Under Semantic Versioning, any breaking change should trigger a major‑version bump.
However, this change doesn’t feel large enough to warrant a new major version, so—if we can keep backward compatibility—it would be preferable to ship it as a minor version update instead.

[y-kawawa]

@aldas If I submit a fix PR, would you be willing to consider merging it?

[aldas]

In which situation/use-case this change broke existing/expected behavior? I can not decide without knowing what we have broken.

[y-kawawa]

@aldas
Use case:
A non‑browser client issues a GET request with a disallowed origin.

Previously, the handler that runs after the CORSMiddleware was still executed, but with this change it is skipped and the server now returns 401.
As a result, the client implementation would need to be updated.

[jub0bs]

@aldas Although this isn't specified by the Fetch standard, I would argue that no CORS middleware should block non-preflight requests; such requests should be let through. One reason is that not all requests that carry an Origin header participate in the CORS protocol. For example, open a browser tab on https://example.com and run the following code in the console:

fetch("//example.org", {mode:"no-cors", method:"POST"}) // carries an Origin header but isn't a CORS request

There may be good reasons to block such a request, but a CORS middleware shouldn't be expected to do that.

If the request's origin isn't allowed by the CORS configuration, the middleware should simply omit the relevant CORS headers from the response and let the browser fail the CORS check (if any).

---

@y-kawawa That is what github.com/jub0bs/cors does, and you can make it work with Echo.

[jub0bs]

Related: #2534

[aldas]

reverted, and it will not be included in next patch version v4.13.4 (due being reverted)