[draft] Support map::Trie#children #37
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @shanecelis — based on #35 I've drafted the following implementation.
I'm a rust noob so would be happy to take feedback on this; in particular, I think my trait constraints are correct, but could definitely use some extra eyes on that!
The traversal code I copied from
longest_prefixthough it's possible we should instead support an exact match only..?This code also implements
children_valuesandchildren_labels, wherechildren_labelscan accept a booleanterminals_onlyflag so that only labels for terminal nodes are returned (i.e., direct descendants) instead of for subtries as well.