Skip to content

Commit b88a866

Browse files
committed
Formatting, remove rustfmt skips
1 parent 6f78908 commit b88a866

File tree

2 files changed

+77
-44
lines changed

2 files changed

+77
-44
lines changed

lightning/src/ln/channel.rs

Lines changed: 37 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -10404,35 +10404,41 @@ where
1040410404
/// - `our_funding_inputs`: the inputs we contribute to the new funding transaction.
1040510405
/// Includes the witness weight for this input (e.g. P2WPKH_WITNESS_WEIGHT=109 for typical P2WPKH inputs).
1040610406
#[cfg(splicing)]
10407-
#[rustfmt::skip]
10408-
pub fn splice_channel(&mut self, our_funding_contribution_satoshis: i64,
10409-
our_funding_inputs: Vec<(TxIn, Transaction, Weight)>,
10410-
funding_feerate_per_kw: u32, locktime: u32,
10407+
pub fn splice_channel(
10408+
&mut self, our_funding_contribution_satoshis: i64,
10409+
our_funding_inputs: Vec<(TxIn, Transaction, Weight)>, funding_feerate_per_kw: u32,
10410+
locktime: u32,
1041110411
) -> Result<msgs::SpliceInit, APIError> {
1041210412
// Check if a splice has been initiated already.
1041310413
// Note: only a single outstanding splice is supported (per spec)
1041410414
if let Some(pending_splice) = &self.pending_splice {
10415-
return Err(APIError::APIMisuseError { err: format!(
10415+
return Err(APIError::APIMisuseError {
10416+
err: format!(
1041610417
"Channel {} cannot be spliced, as it has already a splice pending (contribution {})",
1041710418
self.context.channel_id(),
1041810419
pending_splice.our_funding_contribution,
10419-
)});
10420+
),
10421+
});
1042010422
}
1042110423

1042210424
if !self.context.is_live() {
10423-
return Err(APIError::APIMisuseError { err: format!(
10424-
"Channel {} cannot be spliced, as channel is not live",
10425-
self.context.channel_id()
10426-
)});
10425+
return Err(APIError::APIMisuseError {
10426+
err: format!(
10427+
"Channel {} cannot be spliced, as channel is not live",
10428+
self.context.channel_id()
10429+
),
10430+
});
1042710431
}
1042810432

1042910433
// TODO(splicing): check for quiescence
1043010434

1043110435
if our_funding_contribution_satoshis < 0 {
10432-
return Err(APIError::APIMisuseError { err: format!(
10436+
return Err(APIError::APIMisuseError {
10437+
err: format!(
1043310438
"TODO(splicing): Splice-out not supported, only splice in; channel ID {}, contribution {}",
1043410439
self.context.channel_id(), our_funding_contribution_satoshis,
10435-
)});
10440+
),
10441+
});
1043610442
}
1043710443

1043810444
// TODO(splicing): Once splice-out is supported, check that channel balance does not go below 0
@@ -10442,11 +10448,20 @@ where
1044210448
// (Cannot test for miminum required post-splice channel value)
1044310449

1044410450
// Check that inputs are sufficient to cover our contribution.
10445-
let _fee = check_v2_funding_inputs_sufficient(our_funding_contribution_satoshis, &our_funding_inputs, true, true, funding_feerate_per_kw)
10446-
.map_err(|err| APIError::APIMisuseError { err: format!(
10451+
let _fee = check_v2_funding_inputs_sufficient(
10452+
our_funding_contribution_satoshis,
10453+
&our_funding_inputs,
10454+
true,
10455+
true,
10456+
funding_feerate_per_kw,
10457+
)
10458+
.map_err(|err| APIError::APIMisuseError {
10459+
err: format!(
1044710460
"Insufficient inputs for splicing; channel ID {}, err {}",
10448-
self.context.channel_id(), err,
10449-
)})?;
10461+
self.context.channel_id(),
10462+
err,
10463+
),
10464+
})?;
1045010465
// Convert inputs
1045110466
let mut funding_inputs = Vec::new();
1045210467
for (tx_in, tx, _w) in our_funding_inputs.into_iter() {
@@ -10456,7 +10471,7 @@ where
1045610471
}
1045710472

1045810473
let funding_negotiation_context = FundingNegotiationContext {
10459-
our_funding_satoshis: 0, // set at later phase
10474+
our_funding_satoshis: 0, // set at later phase
1046010475
their_funding_satoshis: None, // set at later phase
1046110476
funding_tx_locktime: LockTime::from_consensus(locktime),
1046210477
funding_feerate_sat_per_1000_weight: funding_feerate_per_kw,
@@ -10471,7 +10486,11 @@ where
1047110486
received_funding_txid: None,
1047210487
});
1047310488

10474-
let msg = self.get_splice_init(our_funding_contribution_satoshis, funding_feerate_per_kw, locktime);
10489+
let msg = self.get_splice_init(
10490+
our_funding_contribution_satoshis,
10491+
funding_feerate_per_kw,
10492+
locktime,
10493+
);
1047510494
Ok(msg)
1047610495
}
1047710496

lightning/src/ln/channelmanager.rs

Lines changed: 40 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -4538,16 +4538,22 @@ where
45384538

45394539
/// See [`splice_channel`]
45404540
#[cfg(splicing)]
4541-
#[rustfmt::skip]
45424541
fn internal_splice_channel(
4543-
&self, channel_id: &ChannelId, counterparty_node_id: &PublicKey, our_funding_contribution_satoshis: i64,
4544-
our_funding_inputs: Vec<(TxIn, Transaction, Weight)>,
4545-
funding_feerate_per_kw: u32, locktime: Option<u32>,
4542+
&self, channel_id: &ChannelId, counterparty_node_id: &PublicKey,
4543+
our_funding_contribution_satoshis: i64,
4544+
our_funding_inputs: Vec<(TxIn, Transaction, Weight)>, funding_feerate_per_kw: u32,
4545+
locktime: Option<u32>,
45464546
) -> Result<(), APIError> {
45474547
let per_peer_state = self.per_peer_state.read().unwrap();
45484548

4549-
let peer_state_mutex = match per_peer_state.get(counterparty_node_id)
4550-
.ok_or_else(|| APIError::ChannelUnavailable { err: format!("Can't find a peer matching the passed counterparty node_id {}", counterparty_node_id) }) {
4549+
let peer_state_mutex = match per_peer_state.get(counterparty_node_id).ok_or_else(|| {
4550+
APIError::ChannelUnavailable {
4551+
err: format!(
4552+
"Can't find a peer matching the passed counterparty node_id {}",
4553+
counterparty_node_id
4554+
),
4555+
}
4556+
}) {
45514557
Ok(p) => p,
45524558
Err(e) => return Err(e),
45534559
};
@@ -4560,7 +4566,12 @@ where
45604566
hash_map::Entry::Occupied(mut chan_phase_entry) => {
45614567
let locktime = locktime.unwrap_or_else(|| self.current_best_block().height);
45624568
if let Some(chan) = chan_phase_entry.get_mut().as_funded_mut() {
4563-
let msg = chan.splice_channel(our_funding_contribution_satoshis, our_funding_inputs, funding_feerate_per_kw, locktime)?;
4569+
let msg = chan.splice_channel(
4570+
our_funding_contribution_satoshis,
4571+
our_funding_inputs,
4572+
funding_feerate_per_kw,
4573+
locktime,
4574+
)?;
45644575
peer_state.pending_msg_events.push(MessageSendEvent::SendSpliceInit {
45654576
node_id: *counterparty_node_id,
45664577
msg,
@@ -4571,18 +4582,16 @@ where
45714582
err: format!(
45724583
"Channel with id {} is not funded, cannot splice it",
45734584
channel_id
4574-
)
4585+
),
45754586
})
45764587
}
45774588
},
4578-
hash_map::Entry::Vacant(_) => {
4579-
Err(APIError::ChannelUnavailable {
4580-
err: format!(
4581-
"Channel with id {} not found for the passed counterparty node_id {}",
4582-
channel_id, counterparty_node_id,
4583-
)
4584-
})
4585-
},
4589+
hash_map::Entry::Vacant(_) => Err(APIError::ChannelUnavailable {
4590+
err: format!(
4591+
"Channel with id {} not found for the passed counterparty node_id {}",
4592+
channel_id, counterparty_node_id,
4593+
),
4594+
}),
45864595
}
45874596
}
45884597

@@ -8885,18 +8894,23 @@ This indicates a bug inside LDK. Please report this error at https://github.com/
88858894
}
88868895
}
88878896

8888-
#[rustfmt::skip]
8889-
fn internal_tx_msg<HandleTxMsgFn: Fn(&mut Channel<SP>) -> Result<MessageSendEvent, ChannelError>>(
8890-
&self, counterparty_node_id: &PublicKey, channel_id: ChannelId, tx_msg_handler: HandleTxMsgFn
8897+
fn internal_tx_msg<
8898+
HandleTxMsgFn: Fn(&mut Channel<SP>) -> Result<MessageSendEvent, ChannelError>,
8899+
>(
8900+
&self, counterparty_node_id: &PublicKey, channel_id: ChannelId,
8901+
tx_msg_handler: HandleTxMsgFn,
88918902
) -> Result<(), MsgHandleErrInternal> {
88928903
let per_peer_state = self.per_peer_state.read().unwrap();
8893-
let peer_state_mutex = per_peer_state.get(counterparty_node_id)
8894-
.ok_or_else(|| {
8895-
debug_assert!(false);
8896-
MsgHandleErrInternal::send_err_msg_no_close(
8897-
format!("Can't find a peer matching the passed counterparty node_id {}", counterparty_node_id),
8898-
channel_id)
8899-
})?;
8904+
let peer_state_mutex = per_peer_state.get(counterparty_node_id).ok_or_else(|| {
8905+
debug_assert!(false);
8906+
MsgHandleErrInternal::send_err_msg_no_close(
8907+
format!(
8908+
"Can't find a peer matching the passed counterparty node_id {}",
8909+
counterparty_node_id
8910+
),
8911+
channel_id,
8912+
)
8913+
})?;
89008914
let mut peer_state_lock = peer_state_mutex.lock().unwrap();
89018915
let peer_state = &mut *peer_state_lock;
89028916
match peer_state.channel_by_id.entry(channel_id) {

0 commit comments

Comments
 (0)