Hang while editing comment

[ygerlach]

Describe the bug
I just clicked around in timeshift, fooling around. I then started editing a snapshots comment and aborted it. After aborting it, timeshift hang for many seconds (long enough for me to get confused and attach gdb)

To Reproduce
Steps to reproduce the behavior:

1. Edit a snapshots comment
2. Abort without typing anything
3. timeshift hang

i was not able to reproduce it. i guess my ssd was just a bit io-bottlenecked so some operation just got stuck.

gdb Stacktrace

(gdb) bt
#0  0x00007323e35160ab in unlink () at ../sysdeps/unix/syscall-template.S:120
#1  0x00007323e3461e6d in __GI_remove (file=0x6065a9cefdb0 "/run/timeshift/26938/backup/timeshift/snapshots/2025-06-09_18-00-01/info.json")
    at ../sysdeps/posix/remove.c:33
#2  0x00007323e3a30a00 in  () at /lib/x86_64-linux-gnu/libgio-2.0.so.0
#3  0x0000606592e34dec in snapshot_update_control_file (self=0x6065a9be9030) at ../src/Core/Snapshot.vala:380
#4  0x0000606592ed95e4 in __lambda35_ (self=0x6065a9c7fee0, path=0x6065a9c25fb0 "1", new_text=0x6065a9beffe0 "") at ../src/Gtk/SnapshotListBox.vala:241
#5  0x0000606592ed9661 in ___lambda35__gtk_cell_renderer_text_edited
    (_sender=0x6065a9b27cf0, path=0x6065a9c25fb0 "1", new_text=0x6065a9beffe0 "", self=0x6065a9c7fee0) at ../src/Gtk/SnapshotListBox.vala:234
#6  0x00007323e3ff2b01 in  () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#7  0x00007323e463c700 in g_signal_emit_valist () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#8  0x00007323e463c863 in g_signal_emit () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#9  0x00007323e3d5ccaa in  () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#10 0x00007323e461ed2f in g_closure_invoke () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#11 0x00007323e463ac36 in  () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#12 0x00007323e463c614 in g_signal_emit_valist () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#13 0x00007323e463ca8e in g_signal_emit_by_name () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#14 0x00007323e3d4a3d0 in gtk_cell_area_stop_editing () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#15 0x00007323e3f78d63 in  () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#16 0x00007323e3ff0bf5 in  () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#17 0x00007323e463c700 in g_signal_emit_valist () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#18 0x00007323e463c863 in g_signal_emit () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#19 0x00007323e3e07d51 in  () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#20 0x00007323e4623866 in g_cclosure_marshal_VOID__BOXEDv () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#21 0x00007323e463c700 in g_signal_emit_valist () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#22 0x00007323e463c863 in g_signal_emit () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#23 0x00007323e3dffb46 in  () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#24 0x00007323e3e077bf in  () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#25 0x00007323e3e08443 in  () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#26 0x00007323e3dcefa0 in gtk_event_controller_handle_event () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#27 0x00007323e3fa0055 in  () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#28 0x00007323e3fe5b87 in  () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#29 0x00007323e461ed2f in g_closure_invoke () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#30 0x00007323e463a624 in  () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#31 0x00007323e463c026 in g_signal_emit_valist () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#32 0x00007323e463c863 in g_signal_emit () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#33 0x00007323e3fae734 in  () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#34 0x00007323e3e516b0 in  () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#35 0x00007323e3e5255a in gtk_main_do_event () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#36 0x00007323e453c743 in  () at /lib/x86_64-linux-gnu/libgdk-3.so.0
#37 0x00007323e4573f56 in  () at /lib/x86_64-linux-gnu/libgdk-3.so.0
#38 0x00007323e46bfd3b in g_main_context_dispatch () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#39 0x00007323e47152b8 in  () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#40 0x00007323e46bf2b3 in g_main_loop_run () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#41 0x00007323e3e48d2d in gtk_main () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#42 0x0000606592dfd487 in app_gtk_start_application () at ../src/AppGtk.vala:162
#43 0x0000606592dfc85d in app_gtk_main (args=0x7fffb5924448, args_length1=1) at ../src/AppGtk.vala:80
#44 0x0000606592dfc8a9 in main (argc=1, argv=0x7fffb5924448) at ../src/AppGtk.vala:51

Expected behavior
timeshift should not do anything when not editing the comment

System:

• Linux Distribution: linux mint 21.3
• Desktop: Cinnamon 6.0.4
• Application Version: current master (70dbfd8)

[ygerlach]

As it is visible in the stacktrace it got stuck updating the control file. So i just added an if that stops it from doing that, if the text was not changed.

See #425 (0135249)