From 48f29975fe2e47fa0e78ee305f27fabebe679634 Mon Sep 17 00:00:00 2001
From: Erin Howard <elhoward@uw.edu>
Date: Mon, 30 Jun 2025 15:32:17 -0700
Subject: [PATCH 1/2] Revert "Don't send fake angle for LSSTCam tests."

This reverts commit 0b35aa8531df1d0fcac600019b458845d6d25328.
---
 python/tester/upload.py | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/python/tester/upload.py b/python/tester/upload.py
index aec71aca..d3a4923d 100644
--- a/python/tester/upload.py
+++ b/python/tester/upload.py
@@ -299,7 +299,6 @@ def get_samples_lsst(bucket, instrument):
             raise RuntimeError(f"Unable to retrieve JSON sidecar: {sidecar}")
         with sidecar.open("r") as f:
             md = json.load(f)
-        angle_sys = FannedOutVisit.RotSys.SKY
 
         sal_index = INSTRUMENTS[instrument].sal_index
         # Use special sal_index to indicate a subset of detectors
@@ -314,11 +313,6 @@ def get_samples_lsst(bucket, instrument):
         physical_filter = md["FILTER"]
         if instrument == "LATISS":
             physical_filter = f"{physical_filter}~empty"
-        # LSSTCam currently only has lab data, no real sky angle
-        # TODO: remove when switching to on-sky data
-        if instrument == "LSSTCam":
-            angle_sys = FannedOutVisit.RotSys.NONE
-            md["ROTPA"] = 0.0
         visit = FannedOutVisit(
             instrument=instrument,
             detector=_DETECTOR_FROM_RS[instrument][m["raft_sensor"]],
@@ -328,7 +322,7 @@ def get_samples_lsst(bucket, instrument):
             coordinateSystem=FannedOutVisit.CoordSys.ICRS,
             position=[md["RA"], md["DEC"]],
             startTime=astropy.time.Time(md["DATE-BEG"], format="isot", scale="tai").unix_tai,
-            rotationSystem=angle_sys,
+            rotationSystem=FannedOutVisit.RotSys.SKY,
             cameraAngle=md["ROTPA"],
             survey="SURVEY",
             salIndex=sal_index,

From 9bdea8918dfa7ed127e5ecf155372e95ecd89c99 Mon Sep 17 00:00:00 2001
From: Erin Howard <elhoward@uw.edu>
Date: Wed, 2 Jul 2025 14:17:09 -0700
Subject: [PATCH 2/2] Update Playbook Testers section for LSSTCam.

---
 doc/playbook.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/doc/playbook.rst b/doc/playbook.rst
index 8897f164..3b6679da 100644
--- a/doc/playbook.rst
+++ b/doc/playbook.rst
@@ -530,7 +530,7 @@ Sample command line:
 .. code-block:: sh
 
    python upload.py LATISS 3
-   python upload.py LSSTCam 2
+   python upload.py LSSTCam 5
    python upload.py LSSTCam-imSim 2
 
 This script draws images stored in the ``rubin-pp-dev-users`` bucket.
@@ -541,7 +541,7 @@ This script draws images stored in the ``rubin-pp-dev-users`` bucket.
   One of the files, the unobserved group `2024-09-04T05:59:29.342`, has no templates and is known to fail `calibrateImage` in determining PSF.
   This visit can test pipeline fallback features.
 * For LSSTComCamSim, 2 groups, in total 18 raw fits files and their corresponding json metadata files, are curated.
-* For LSSTCam, 2 groups, in total 2 raw fits files and their corresponding json metadata files, are curated.
+* For LSSTCam, 5 groups, in total 10 raw fits files and their corresponding json metadata files, are curated.
 * For LSSTCam-imSim, 2 groups, in total 3 raw fits files and custom-made json metadata files, are curated.
 
 ``python/tester/upload_from_repo.py``: Command line arguments are a configuration file, and the number of groups of images to send.