Skip to content

Commit e46f054

Browse files
Merge branch '613_sliders_do_not_render_correctly_after_toggle_a_screen_mode' of github.com:magento/magento2-page-builder into 609_content-type-toolbar-fullscreen-fix
2 parents 19193f7 + 9ff5d37 commit e46f054

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemCommonTest/SlideItemMoveSlideItemsToRearrangeTest.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,7 @@
9292
<!-- Validate Stage -->
9393
<comment userInput="Validate Stage" stepKey="commentValidateStage"/>
9494
<seeElement selector="{{SlideOnBackend.messageContent('1', PageBuilderSlideItemContent_Slide1.value)}}" stepKey="seeSlideContentAfterSave"/>
95+
<waitForElementNotVisible selector="{{SlideOnBackend.base('2')}}" stepKey="dontSeeNextSlideAfterSave"/>
9596
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="unFocusNavigationAfterSave"/>
9697
<moveMouseOver selector="{{SliderOnStage.activeSlideNavigationDot}}" stepKey="mouseOverActiveSlide1AfterSave"/>
9798
<see userInput="{{PageBuilderSlideItemSlideName_Slide1.value}}" selector="{{SliderOnStage.slideNavigationDotNameTooltip('1')}}" stepKey="seeSlideName1InTooltipAfterSave"/>

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/slider/preview.js

Lines changed: 3 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/slider/preview.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,12 +122,15 @@ export default class Preview extends PreviewCollection {
122122
events.trigger("stage:interactionStop");
123123
}
124124
});
125+
events.on(
126+
`stage:${this.contentType.stageId}:fullScreenModeChangeAfter`,
127+
this.onColumnResize.bind(this, [true]),
128+
);
125129
},
126130
() => $(element).find(".pagebuilder-slide").length === expectedChildren,
127131
);
128132
});
129133
}
130-
131134
/**
132135
* Return an array of options
133136
*
@@ -570,7 +573,7 @@ export default class Preview extends PreviewCollection {
570573
$(this.element).slick("setPosition");
571574
this.checkWidth();
572575
}
573-
}, 250);
576+
}, 400);
574577
}
575578

576579
/**

0 commit comments

Comments
 (0)