Skip to content

Conversation

@maschad
Copy link
Owner

@maschad maschad commented Jun 3, 2025

Summary by CodeRabbit

  • Chores
    • Expanded release support to include both x86_64 and aarch64 architectures for Linux and macOS.
    • Updated artifact naming to clearly indicate platform and architecture.
    • Release artifacts now include the version tag in their filenames.
    • Only Linux x86_64 builds are published automatically in the workflow.

@coderabbitai
Copy link

coderabbitai bot commented Jun 11, 2025

Walkthrough

The release workflow configuration was updated to support both x86_64 and aarch64 architectures for Linux and macOS. Artifact naming now reflects architecture and version, and the publish step is limited to Linux x86_64. Steps were added to package artifacts by platform and architecture before release.

Changes

File(s) Change Summary
.github/workflows/release.yaml Expanded build matrix for aarch64 on Linux and macOS, updated artifact naming conventions, limited publish step to Linux x86_64, added packaging and renaming of artifacts by platform and architecture before release.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant GitHub Actions
    participant Build Matrix (x86_64/aarch64)
    participant Artifact Store
    participant Release Job

    Developer->>GitHub Actions: Push tag / trigger release
    GitHub Actions->>Build Matrix: Build for linux-x86_64, linux-aarch64, macos-x86_64, macos-aarch64
    Build Matrix->>Artifact Store: Upload architecture-specific artifacts
    GitHub Actions->>Release Job: Start create-release
    Release Job->>Artifact Store: Download artifacts
    Release Job->>Release Job: Package and rename artifacts with platform, architecture, and version
    Release Job->>GitHub Actions: Create release with all renamed artifacts
Loading

Poem

Hopping through the matrix wide,
Now both arches we provide!
Linux, Mac, in twos they come,
With names that show just where they're from.
A tag, a triple, a tidy release—
More platforms now, our joy won't cease!
🐰✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 28ec177 and 98222b9.

📒 Files selected for processing (1)
  • .github/workflows/release.yaml (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/release.yaml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (1)
.github/workflows/release.yaml (1)

95-99: Windows artifacts not versioned or packaged
Unlike Linux/macOS, the Windows runner uploads raw binaries without versioned filenames or a zip archive. Consider packaging the .exe into a zip and renaming it with the tag and target triple for consistency:

- name: Package Windows artifacts
  run: |
    cd artifacts/junkanoo-windows
    zip junkanoo-${{ github.ref_name }}-x86_64-pc-windows-msvc.zip junkanoo.exe
    rm junkanoo.exe
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3313958 and 28ec177.

📒 Files selected for processing (1)
  • .github/workflows/release.yaml (3 hunks)
🔇 Additional comments (3)
.github/workflows/release.yaml (3)

24-28: Build matrix now includes Linux aarch64
The combination ubuntu-latest + aarch64-unknown-linux-gnu has been added with its own artifact_name. This aligns with the PR objective to support aarch64 on Linux.


33-37: Build matrix now includes macOS aarch64
Adding macos-latest + aarch64-apple-darwin mirrors the Linux change and completes CI coverage for Apple Silicon. Looks good.


54-54: Restrict crates.io publish to Linux x86_64
The if guard ensures only the Linux x86_64 runner publishes to crates.io, preventing duplicate publishes from other matrix entries.

@maschad maschad merged commit 092c435 into main Jun 19, 2025
3 checks passed
@maschad maschad deleted the mc/ci/update-release-workflow branch June 19, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants