-
Notifications
You must be signed in to change notification settings - Fork 0
ci: update release workflow #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe artifact upload step in the release workflow was updated to use an explicit conditional to select the correct executable path based on the operating system. This replaces a wildcard pattern with a direct check for Windows or Unix-style executables during the build process. Changes
Possibly related PRs
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/release.yaml (1)
77-77: Quote conditional path expression for YAML safety
The interpolation contains characters like:and logical operators that can be misparsed by YAML. Wrap the entire expression in quotes to ensure it’s treated as a single string.- path: ${{ matrix.os == 'windows-latest' && format('target/{0}/release/junkanoo.exe', matrix.target) || format('target/{0}/release/junkanoo', matrix.target) }} + path: "${{ matrix.os == 'windows-latest' && format('target/{0}/release/junkanoo.exe', matrix.target) || format('target/{0}/release/junkanoo', matrix.target) }}"Would you like an example of splitting this into two upload steps (one for Windows, one for Unix) to improve readability?
Summary by CodeRabbit