Feature 3507 introduce x sechub dast header #3512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
winzj
commented
Oct 14, 2024
winzj
commented
- closes Introduce x-sechub-dast http header for webscans #3507
- closes Improve SecHub DAST user messages for scanned URLs #3511
- add x-sechub-dast header containing jobUUID - add cleanup after scan - update mocked test cases
- add more information on scanned URLs to user messages - make necessary change to unit tests - minor logging fixes
de-jcup
requested changes
Oct 16, 2024
...asp-zap/src/main/java/com/mercedesbenz/sechub/zapwrapper/helper/ZapProductMessageHelper.java
Outdated
Show resolved
Hide resolved
...asp-zap/src/main/java/com/mercedesbenz/sechub/zapwrapper/helper/ZapProductMessageHelper.java
Outdated
Show resolved
Hide resolved
...asp-zap/src/main/java/com/mercedesbenz/sechub/zapwrapper/helper/ZapProductMessageHelper.java
Outdated
Show resolved
Hide resolved
sechub-wrapper-owasp-zap/src/main/java/com/mercedesbenz/sechub/zapwrapper/scan/ZapScanner.java
Show resolved
Hide resolved
sechub-wrapper-owasp-zap/src/main/java/com/mercedesbenz/sechub/zapwrapper/scan/ZapScanner.java
Show resolved
Hide resolved
sechub-wrapper-owasp-zap/src/main/java/com/mercedesbenz/sechub/zapwrapper/scan/ZapScanner.java
Show resolved
Hide resolved
...-wrapper-owasp-zap/src/test/java/com/mercedesbenz/sechub/zapwrapper/scan/ZapScannerTest.java
Outdated
Show resolved
Hide resolved
...wasp-zap/src/main/java/com/mercedesbenz/sechub/zapwrapper/internal/scan/ClientApiFacade.java
Show resolved
Hide resolved
...asp-zap/src/main/java/com/mercedesbenz/sechub/zapwrapper/helper/ZapProductMessageHelper.java
Outdated
Show resolved
Hide resolved
- added explanations to unspecific parts - replaced user messageds with logging - correctly ordered scanners - improved user messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.