From 322712c1bd97e109a2922e16ca55064b84717ad6 Mon Sep 17 00:00:00 2001 From: Gokul Gunasekaran Date: Thu, 25 Jul 2024 23:04:24 -0700 Subject: [PATCH 1/4] stateful dl smoke test Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: --- test/smoke_test/smoke_test.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/test/smoke_test/smoke_test.py b/test/smoke_test/smoke_test.py index d3ad74ba2..d3bf55373 100644 --- a/test/smoke_test/smoke_test.py +++ b/test/smoke_test/smoke_test.py @@ -16,6 +16,10 @@ def s3_test(): from torchdata._torchdata import S3Handler +def stateful_dataloader_test(): + from torchdata.stateful_dataloader import StatefulDataLoader + + if __name__ == "__main__": r""" TorchData Smoke Test @@ -26,3 +30,7 @@ def s3_test(): options = parser.parse_args() if options.s3: s3_test() + + if torchdata.__version__ != "0.8.0": + raise Exception("TorchData version is not 0.8.0") + stateful_dataloader_test() From 0a1fc12fe2f260605445c9deceeb838330261b28 Mon Sep 17 00:00:00 2001 From: Gokul Gunasekaran Date: Fri, 26 Jul 2024 12:27:40 -0700 Subject: [PATCH 2/4] print version that was found --- test/smoke_test/smoke_test.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/smoke_test/smoke_test.py b/test/smoke_test/smoke_test.py index d3bf55373..3531d8478 100644 --- a/test/smoke_test/smoke_test.py +++ b/test/smoke_test/smoke_test.py @@ -32,5 +32,5 @@ def stateful_dataloader_test(): s3_test() if torchdata.__version__ != "0.8.0": - raise Exception("TorchData version is not 0.8.0") + raise Exception(f"TorchData version is not 0.8.0, found {torchdata.__version__}") stateful_dataloader_test() From 38beea501bc88135a5d61b776d76084a31bc9f25 Mon Sep 17 00:00:00 2001 From: Gokul Gunasekaran Date: Fri, 26 Jul 2024 12:47:25 -0700 Subject: [PATCH 3/4] starts with instead of strict equality --- test/smoke_test/smoke_test.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/smoke_test/smoke_test.py b/test/smoke_test/smoke_test.py index 3531d8478..3797327c3 100644 --- a/test/smoke_test/smoke_test.py +++ b/test/smoke_test/smoke_test.py @@ -31,6 +31,6 @@ def stateful_dataloader_test(): if options.s3: s3_test() - if torchdata.__version__ != "0.8.0": + if torchdata.__version__.startswith("0.8.0"): raise Exception(f"TorchData version is not 0.8.0, found {torchdata.__version__}") stateful_dataloader_test() From f4d098655b921eb5ee5abe3882866512f546a113 Mon Sep 17 00:00:00 2001 From: Gokul Gunasekaran Date: Fri, 26 Jul 2024 13:25:51 -0700 Subject: [PATCH 4/4] missed negation --- test/smoke_test/smoke_test.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/smoke_test/smoke_test.py b/test/smoke_test/smoke_test.py index 3797327c3..7643676de 100644 --- a/test/smoke_test/smoke_test.py +++ b/test/smoke_test/smoke_test.py @@ -31,6 +31,6 @@ def stateful_dataloader_test(): if options.s3: s3_test() - if torchdata.__version__.startswith("0.8.0"): + if not torchdata.__version__.startswith("0.8.0"): raise Exception(f"TorchData version is not 0.8.0, found {torchdata.__version__}") stateful_dataloader_test()