-
Notifications
You must be signed in to change notification settings - Fork 34
Enforce unique result in list-fix-paths #687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@TobiasNx look at ther error:
You may just have put some extra spaces or somethin along the line. |
Thanks to @blackwinter the checkstyle is not failing anymore. @dr0i can you help me with tests? |
@dr0i you changed the option here: 53c2e6b#diff-169b6a53d763d640ae1f135fea90ead61c4f2219219ab9539d8c21d0390aeebcR62 This makes the result no fix paths anymore. You could not use it anymore in a fix transformation, we need the index position for that. e.g. c.2 is a fix path, but c is only the path to the array, you could not use PS: This also puts two changes into one commit that should have been two commits. |
e0077cc
to
d5ff80d
Compare
I've modified the test, see d5ff80d. |
I think I understand how to adjust the test now. Can I add another record to the test like this. Duplicate elements are already tested. I need to test duplicate field/values in multiple records. See: #686 (comment)
|
you can add the test - why shouldn't you? |
Done |
cdaa04e
to
9956282
Compare
9956282
to
6a4f548
Compare
As discussed: readd the Mockito test and adapt the test to be successful, then assign @blackwinter for review. |
metafix/src/test/java/org/metafacture/metafix/FindFixPathsTest.java
Outdated
Show resolved
Hide resolved
Duplicate field was consecutive by coincidence, since all fields in between were filtered. With added result field we need to sort.
Resolves #686.
@dr0i fixed the error could you help me with adding a test.