fix(lbac-3200): appel classification cfa (#2378)

Author: remy-auricoste

server/src/jobs/offrePartenaire/detectClassificationJobsPartners.test.ts

@@ -0,0 +1,123 @@
+import nock from "nock"
+import { IClassificationLabBatchResponse } from "shared/models/cacheClassification.model"
+import { COMPUTED_ERROR_SOURCE } from "shared/models/jobsPartnersComputed.model"
+import { beforeEach, describe, expect, it } from "vitest"
+
+import { getDbCollection } from "@/common/utils/mongodbUtils"
+import config from "@/config"
+import { detectClassificationJobsPartners as detectClassificationJobsPartnersRaw } from "@/jobs/offrePartenaire/detectClassificationJobsPartners"
+import { givenSomeComputedJobPartners } from "@tests/fixture/givenSomeComputedJobPartners"
+import { useMongo } from "@tests/utils/mongo.test.utils"
+
+const detectClassificationJobsPartners = () => detectClassificationJobsPartnersRaw({ shouldNotifySlack: false })
+
+const offer_title = "vendeur / vendeuse"
+const workplace_name = "decathlon"
+const workplace_description = "description d'un magasin decathlon"
+const offer_description = "description d'une offre de vendeur"
+const partner_job_id = "partner_job_id"
+
+describe("detectClassificationJobsPartners", () => {
+  useMongo()
+
+  beforeEach(() => {
+    const apiResponse: IClassificationLabBatchResponse = [
+      {
+        id: partner_job_id,
+        label: "entreprise",
+        model: "model",
+        scores: { cfa: 0.5, entreprise: 0.4, entreprise_cfa: 0.2 },
+        text: "Software Engineer",
+      },
+    ]
+    nock(config.labonnealternanceLab.baseUrl).post("/scores").reply(200, apiResponse)
+    return async () => {
+      await getDbCollection("computed_jobs_partners").deleteMany({})
+    }
+  })
+
+  it("should pass on a job partner with all fields", async () => {
+    // given
+    await givenSomeComputedJobPartners([
+      {
+        partner_job_id,
+        offer_title,
+        workplace_name,
+        workplace_description,
+        offer_description,
+      },
+    ])
+    // when
+    await detectClassificationJobsPartners()
+    // then
+    const jobs = await getDbCollection("computed_jobs_partners").find({}).toArray()
+    expect.soft(jobs.length).toEqual(1)
+    const [job] = jobs
+    expect.soft(job.jobs_in_success.includes(COMPUTED_ERROR_SOURCE.CLASSIFICATION)).toEqual(true)
+  })
+
+  it("should pass on a job partner with only a title", async () => {
+    // given
+    await givenSomeComputedJobPartners([
+      {
+        partner_job_id,
+        offer_title,
+      },
+    ])
+    // when
+    await detectClassificationJobsPartners()
+    // then
+    const jobs = await getDbCollection("computed_jobs_partners").find({}).toArray()
+    expect.soft(jobs.length).toEqual(1)
+    const [job] = jobs
+    expect.soft(job.jobs_in_success.includes(COMPUTED_ERROR_SOURCE.CLASSIFICATION)).toEqual(true)
+  })
+  it("should pass on a job partner with only a workplace name", async () => {
+    // given
+    await givenSomeComputedJobPartners([
+      {
+        partner_job_id,
+        workplace_name,
+      },
+    ])
+    // when
+    await detectClassificationJobsPartners()
+    // then
+    const jobs = await getDbCollection("computed_jobs_partners").find({}).toArray()
+    expect.soft(jobs.length).toEqual(1)
+    const [job] = jobs
+    expect.soft(job.jobs_in_success.includes(COMPUTED_ERROR_SOURCE.CLASSIFICATION)).toEqual(true)
+  })
+  it("should pass on a job partner with only a workplace description", async () => {
+    // given
+    await givenSomeComputedJobPartners([
+      {
+        partner_job_id,
+        workplace_description,
+      },
+    ])
+    // when
+    await detectClassificationJobsPartners()
+    // then
+    const jobs = await getDbCollection("computed_jobs_partners").find({}).toArray()
+    expect.soft(jobs.length).toEqual(1)
+    const [job] = jobs
+    expect.soft(job.jobs_in_success.includes(COMPUTED_ERROR_SOURCE.CLASSIFICATION)).toEqual(true)
+  })
+  it("should pass on a job partner with only an offer description", async () => {
+    // given
+    await givenSomeComputedJobPartners([
+      {
+        partner_job_id,
+        offer_description,
+      },
+    ])
+    // when
+    await detectClassificationJobsPartners()
+    // then
+    const jobs = await getDbCollection("computed_jobs_partners").find({}).toArray()
+    expect.soft(jobs.length).toEqual(1)
+    const [job] = jobs
+    expect.soft(job.jobs_in_success.includes(COMPUTED_ERROR_SOURCE.CLASSIFICATION)).toEqual(true)
+  })
+})

server/src/jobs/offrePartenaire/detectClassificationJobsPartners.ts

@@ -10,9 +10,6 @@ export const detectClassificationJobsPartners = async ({ addedMatchFilter, shoul
   const filledFields = ["business_error"] as const satisfies (keyof IComputedJobsPartners)[]
   const filters: Filter<IComputedJobsPartners>[] = [
     {
-      workplace_description: { $ne: null },
-      workplace_name: { $ne: null },
-      offer_description: { $ne: null },
       business_error: null,
     },
   ]
@@ -29,10 +26,10 @@ export const detectClassificationJobsPartners = async ({ addedMatchFilter, shoul
       const payload = documents.map((document) => {
         const { workplace_description, offer_description, offer_title, workplace_name, partner_job_id, partner_label } = document
         return {
-          workplace_name: workplace_name!,
-          workplace_description: workplace_description!,
-          offer_title: offer_title!,
-          offer_description: offer_description!,
+          workplace_name: workplace_name ?? undefined,
+          workplace_description: workplace_description ?? undefined,
+          offer_title: offer_title ?? undefined,
+          offer_description: offer_description ?? undefined,
           partner_job_id,
           partner_label,
         }

server/src/services/cacheClassification.service.ts

@@ -7,10 +7,10 @@ import { getDbCollection } from "@/common/utils/mongodbUtils"
 export type TJobClassification = {
   partner_label: string
   partner_job_id: string
-  workplace_name: string
-  workplace_description: string
-  offer_title: string
-  offer_description: string
+  workplace_name?: string
+  workplace_description?: string
+  offer_title?: string
+  offer_description?: string
 }
 
 const getClassificationFromDB = async (jobs: TJobClassification[]): Promise<(IClassificationJobsPartners | null)[]> => {