Skip to content

Commit dcb4f21

Browse files
authored
Change sample server host from 0.0.0.0 to 127.0.0.1 (#307)
Don't bind the sample server to `0.0.0.0` by default as that exposes the server to anyone else on the local network. If anyone were to use these samples as staring points to build larger services, those servers would thus expose developers to attack immediately upon launch. I'd prefer if we avoided that 😆 ## Motivation and Context 🔒 Security ## How Has This Been Tested? <!-- Have you tested this in a real application? Which scenarios were tested? --> I haven't checked out the code locally to verify it works. All the editing to the code was done on GitHub.com ## Breaking Changes <!-- Will users need to update their code or configurations? --> No. ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. --> - [ ] I have read the [MCP Documentation](https://modelcontextprotocol.io) - [ ] My code follows the repository's style guidelines - [ ] New and existing tests pass locally - [ ] I have added appropriate error handling - [ ] I have added or updated documentation as needed ## Additional context <!-- Add any other context, implementation notes, or design decisions -->
1 parent 14e86b2 commit dcb4f21

File tree

1 file changed

+2
-2
lines changed
  • samples/kotlin-mcp-server/src/commonMain/kotlin

1 file changed

+2
-2
lines changed

samples/kotlin-mcp-server/src/commonMain/kotlin/server.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ suspend fun runSseMcpServerWithPlainConfiguration(port: Int) {
101101

102102
val server = configureServer()
103103

104-
embeddedServer(CIO, host = "0.0.0.0", port = port) {
104+
embeddedServer(CIO, host = "127.0.0.1", port = port) {
105105
install(SSE)
106106
routing {
107107
sse("/sse") {
@@ -145,7 +145,7 @@ suspend fun runSseMcpServerUsingKtorPlugin(port: Int) {
145145
println("Starting sse server on port $port")
146146
println("Use inspector to connect to the http://localhost:$port/sse")
147147

148-
embeddedServer(CIO, host = "0.0.0.0", port = port) {
148+
embeddedServer(CIO, host = "127.0.0.1", port = port) {
149149
mcp {
150150
return@mcp configureServer()
151151
}

0 commit comments

Comments
 (0)